Skip to content

Commit 4990664

Browse files
committed
CI: check all proofs without time limit
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
1 parent dca6876 commit 4990664

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

.github/scripts/check_proofs.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
parser = ArgumentParser(description='Validate all proofs in all modules with TLAPM.')
1414
parser.add_argument('--tlapm_path', help='Path to TLAPM install dir; should have bin and lib subdirs', required=False, default = 'deps/tlapm')
1515
parser.add_argument('--examples_root', help='Root directory of the tlaplus/examples repository', required=False, default='.')
16-
parser.add_argument('--runtime_seconds_limit', help='Only run proofs with expected runtime less than this value', required=False, default=60)
1716
parser.add_argument('--skip', nargs='+', help='Space-separated list of .tla modules to skip checking', required=False, default=[])
1817
parser.add_argument('--only', nargs='+', help='If provided, only check proofs in this space-separated list', required=False, default=[])
1918
parser.add_argument('--verbose', help='Set logging output level to debug', action='store_true')
@@ -24,17 +23,15 @@
2423
manifest = tla_utils.load_all_manifests(examples_root)
2524
skip_modules = args.skip
2625
only_modules = args.only
27-
hard_timeout_in_seconds = args.runtime_seconds_limit * 2
2826

2927
logging.basicConfig(level = logging.DEBUG if args.verbose else logging.INFO)
3028

3129
proof_module_paths = sorted(
3230
[
33-
(manifest_dir, spec, module, runtime)
31+
(manifest_dir, spec, module, tla_utils.parse_timespan(module['proof']['runtime']))
3432
for manifest_dir, spec in manifest
3533
for module in spec['modules']
3634
if 'proof' in module
37-
and (runtime := tla_utils.parse_timespan(module['proof']['runtime'])) <= timedelta(seconds = args.runtime_seconds_limit)
3835
and module['path'] not in skip_modules
3936
and (only_modules == [] or module['path'] in only_modules)
4037
],
@@ -61,8 +58,7 @@
6158
],
6259
stdout = subprocess.PIPE,
6360
stderr = subprocess.STDOUT,
64-
text = True,
65-
timeout = hard_timeout_in_seconds
61+
text = True
6662
)
6763
end_time = timer()
6864
actual_runtime = timedelta(seconds = end_time - start_time)

0 commit comments

Comments
 (0)