Skip to content

Commit 39cdc6e

Browse files
committed
reorderd evaluation of parameters
1 parent dae4c28 commit 39cdc6e

File tree

1 file changed

+31
-12
lines changed

1 file changed

+31
-12
lines changed

TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/config/delegate/CertificateDelegate.java

Lines changed: 31 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -78,26 +78,32 @@ public void setAlias(String alias) {
7878
this.alias = alias;
7979
}
8080

81+
public String getCertificate() {
82+
return certificate;
83+
}
84+
85+
public void setCertificate(String certificate) {
86+
this.certificate = certificate;
87+
}
88+
89+
public String getKey() {
90+
return key;
91+
}
92+
93+
public void setKey(String key) {
94+
this.key = key;
95+
}
96+
8197
@Override
8298
public void applyDelegate(Config config) {
8399
Map<String, String> mandatoryParameters = new HashMap<>();
84100
mandatoryParameters.put("keystore", keystore);
85101
mandatoryParameters.put("password", password);
86102
mandatoryParameters.put("alias", alias);
87-
List<String> missingParameters = new ArrayList<>();
88-
for (String p : mandatoryParameters.keySet()) {
89-
if (mandatoryParameters.get(p) == null) {
90-
missingParameters.add(p);
91-
}
92-
}
93-
if (missingParameters.size() == 3) {
94-
return;
95-
} else if (!missingParameters.isEmpty()) {
96-
throw new ParameterException("The following parameters are required for loading a" + " keystore: "
97-
+ join(mandatoryParameters.keySet()));
98-
}
103+
99104
PrivateKey privateKey = null;
100105
if (key != null) {
106+
LOGGER.debug("Loading private key");
101107
try {
102108
privateKey = PemUtil.readPrivateKey(new File(key));
103109
CustomPrivateKey customPrivateKey = CertificateUtils.parseCustomPrivateKey(privateKey);
@@ -109,6 +115,7 @@ public void applyDelegate(Config config) {
109115
}
110116
}
111117
if (certificate != null) {
118+
LOGGER.debug("Loading ceritificate");
112119
try {
113120
Certificate cert = PemUtil.readCertificate(new File(certificate));
114121
if (privateKey != null) {
@@ -121,6 +128,18 @@ public void applyDelegate(Config config) {
121128
LOGGER.warn("Could not read certificate", ex);
122129
}
123130
}
131+
List<String> missingParameters = new ArrayList<>();
132+
for (String p : mandatoryParameters.keySet()) {
133+
if (mandatoryParameters.get(p) == null) {
134+
missingParameters.add(p);
135+
}
136+
}
137+
if (missingParameters.size() == 3) {
138+
return;
139+
} else if (!missingParameters.isEmpty()) {
140+
throw new ParameterException("The following parameters are required for loading a" + " keystore: "
141+
+ join(mandatoryParameters.keySet()));
142+
}
124143
try {
125144
ConnectionEndType type;
126145
switch (config.getDefaultRunningMode()) {

0 commit comments

Comments
 (0)