Fixed ==/equals comparision - this is kind of tricky as it can lead to bugs if the objects come from a different classloader

Author: ic0ns

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/Main.java

@@ -16,6 +16,7 @@
 import de.rub.nds.tlsattacker.core.config.delegate.GeneralDelegate;
 import de.rub.nds.tlsattacker.core.exceptions.ConfigurationException;
 import static de.rub.nds.tlsattacker.util.ConsoleLogger.CONSOLE;
+import java.util.Objects;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
@@ -137,9 +138,9 @@ public static void main(String[] args) {
             } else {
                 try {
                     Boolean result = attacker.checkVulnerability();
-                    if (result == Boolean.TRUE) {
+                    if (Objects.equals(result, Boolean.TRUE)) {
                         CONSOLE.error("Vulnerable:" + result.toString());
-                    } else if (result == Boolean.FALSE) {
+                    } else if (Objects.equals(result, Boolean.FALSE)) {
                         CONSOLE.info("Vulnerable:" + result.toString());
                     } else {
                         CONSOLE.warn("Vulnerable: Uncertain");

TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/workflow/factory/WorkflowConfigurationFactory.java

@@ -57,6 +57,7 @@
 import java.util.ArrayList;
 import java.util.LinkedList;
 import java.util.List;
+import java.util.Objects;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
@@ -179,7 +180,7 @@ public WorkflowTrace createHelloWorkflow(AliasedConnection connection) {
         List<ProtocolMessage> messages = new LinkedList<>();
         messages.add(new ServerHelloMessage(config));
         if (config.getHighestProtocolVersion().isTLS13()) {
-            if (config.getTls13BackwardsCompatibilityMode() == Boolean.TRUE) {
+            if (Objects.equals(config.getTls13BackwardsCompatibilityMode(), Boolean.TRUE)) {
                 messages.add(new ChangeCipherSpecMessage());
             }
             messages.add(new EncryptedExtensionsMessage(config));
@@ -860,7 +861,7 @@ private WorkflowTrace createDynamicHandshakeWorkflow() {
             messages.add(new ServerHelloMessage(config));
 
             if (config.getHighestProtocolVersion().isTLS13()) {
-                if (config.getTls13BackwardsCompatibilityMode() == Boolean.TRUE) {
+                if (Objects.equals(config.getTls13BackwardsCompatibilityMode(), Boolean.TRUE)) {
                     messages.add(new ChangeCipherSpecMessage());
                 }
                 messages.add(new EncryptedExtensionsMessage(config));