Skip to content

Commit 9866c4a

Browse files
committed
Fix NullPointerException Error with static extensionMessage
1 parent 9203671 commit 9866c4a

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

TLS-Core/src/test/java/de/rub/nds/tlsattacker/core/protocol/handler/HelloRetryRequestHandlerTest.java

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,15 @@
1212
import de.rub.nds.tlsattacker.core.constants.ProtocolVersion;
1313
import de.rub.nds.tlsattacker.core.protocol.message.HelloRetryRequestMessage;
1414
import de.rub.nds.tlsattacker.core.protocol.message.extension.ExtensionMessage;
15+
import de.rub.nds.tlsattacker.core.protocol.message.extension.EncryptThenMacExtensionMessage;
1516
import de.rub.nds.tlsattacker.core.protocol.parser.HelloRetryRequestParser;
1617
import de.rub.nds.tlsattacker.core.protocol.preparator.HelloRetryRequestPreparator;
1718
import de.rub.nds.tlsattacker.core.protocol.serializer.HelloRetryRequestSerializer;
1819
import de.rub.nds.tlsattacker.core.state.TlsContext;
19-
import de.rub.nds.tlsattacker.transport.ConnectionEndType;
2020

2121
import org.junit.Before;
2222
import org.junit.Test;
23-
import java.util.List;
2423

25-
import de.rub.nds.tlsattacker.core.protocol.MessageFactory;
2624
import de.rub.nds.tlsattacker.core.constants.ExtensionType;
2725

2826

@@ -57,30 +55,22 @@ public void testGetSerializer(){
5755
@Test
5856
public void testAdjustTLSContext(){
5957
HelloRetryRequestMessage message = new HelloRetryRequestMessage();
58+
ExtensionMessage extensionMessage = new EncryptThenMacExtensionMessage();
6059
ProtocolVersion protocolVersion = ProtocolVersion.SSL2;
6160
CipherSuite cipherSuite = CipherSuite.TLS_DH_DSS_WITH_DES_CBC_SHA;
62-
ExtensionType extensionType = ExtensionType.SERVER_NAME_INDICATION;
63-
List<ExtensionMessage> extensionMessages = MessageFactory.generateExtensionMessages();
61+
ExtensionType extensionType = ExtensionType.ENCRYPT_THEN_MAC;
62+
6463

6564
message.setProtocolVersion(protocolVersion.getValue());
6665
message.setSelectedCipherSuite(cipherSuite.getByteValue());
6766
message.setExtensionBytes(extensionType.getValue());
68-
69-
message.addExtension(extensionMessages.get(0));
67+
message.addExtension(extensionMessage);
7068

7169
handler.adjustTLSContext(message);
72-
ExtensionType type = ExtensionType.getExtensionType(message.getExtensions().get(0).getExtensionTypeConstant().getValue());
73-
7470

7571
assertSame(context.getSelectedProtocolVersion(),protocolVersion);
7672
assertSame(context.getSelectedCipherSuite(), cipherSuite);
77-
assertEquals(context.getProposedExtensions().toString(),"["+type+"]");
78-
79-
if(context.getTalkingConnectionEndType() == ConnectionEndType.CLIENT){
80-
assertTrue(context.isExtensionProposed(type));
81-
}else if(context.getTalkingConnectionEndType() == ConnectionEndType.SERVER){
82-
assertTrue(context.isExtensionNegotiated(type));
83-
}
73+
assertTrue(context.isExtensionProposed(extensionType));
8474

8575
}
8676

0 commit comments

Comments
 (0)