Merge pull request #378 from RUB-NDS/v21release

V21release

Author: ic0ns

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/config/PskBruteForcerAttackClientCommandConfig.java

@@ -24,10 +24,6 @@
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.core.config.Configurator;
 
-/**
- *
- * @author florian
- */
 public class PskBruteForcerAttackClientCommandConfig extends AttackConfig {
     public static final String ATTACK_COMMAND = "pskbruteforcerclient";
 

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/config/PskBruteForcerAttackServerCommandConfig.java

@@ -24,10 +24,6 @@
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.core.config.Configurator;
 
-/**
- *
- * @author florian
- */
 public class PskBruteForcerAttackServerCommandConfig extends AttackConfig {
     public static final String ATTACK_COMMAND = "pskbruteforcerserver";
 

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/config/TooManyAlgorithmsAttackConfig.java

@@ -15,10 +15,6 @@
 import de.rub.nds.tlsattacker.core.config.delegate.HostnameExtensionDelegate;
 import de.rub.nds.tlsattacker.core.config.delegate.ProtocolVersionDelegate;
 
-/**
- *
- * @author Robert Merget <robert.merget@rub.de>
- */
 public class TooManyAlgorithmsAttackConfig extends AttackConfig {
 
     public static final String ATTACK_COMMAND = "too_many_algorithms";

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/ec/ICEAttacker.java

@@ -177,9 +177,13 @@ private void attackOracle() {
      * compute the server private key with CRT.
      * 
      * @param usedOracleEquations
+     *            The used oracle equations
      * @param congs
+     *            The congruences
      * @param modulis
+     *            The modulis
      * @param pointer
+     *            the pointer
      */
     public void bruteForceWithAdditionalOracleEquations(int[] usedOracleEquations, BigInteger[] congs,
             BigInteger[] modulis, int pointer) {
@@ -209,9 +213,12 @@ public void bruteForceWithAdditionalOracleEquations(int[] usedOracleEquations, B
      * Computes CRT from a given combination of congs and modulis
      * 
      * @param usedOracleEquations
+     *            The used oracle equations
      * @param congs
+     *            The congruences
      * @param modulis
-     * @return
+     *            The modulis
+     * @return CRTF
      */
     private BigInteger computeCRTFromCombination(int[] usedOracleEquations, BigInteger[] congs, BigInteger[] modulis) {
         BigInteger[] usedCongs = new BigInteger[usedOracleEquations.length];
@@ -235,7 +242,8 @@ private int[] initializeUsedOracleEquations(int size) {
      * Uses the oracle to get a congruence for a specific point
      * 
      * @param point
-     * @return
+     *            A Point
+     * @return The Congruence
      */
     private BigInteger getCongruence(ICEPoint point) {
         BigInteger secretModOrder = BigInteger.ZERO;

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/ec/ICEPointReader.java

@@ -28,7 +28,8 @@ public class ICEPointReader {
      * this named curve
      * 
      * @param namedCurve
-     * @return
+     *            The NamedCurve as a String
+     * @return the deserialized Points
      */
     public static List<ICEPoint> readPoints(String namedCurve) {
         String namedCurveLow = namedCurve.toLowerCase();

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/ec/oracles/ECOracle.java

@@ -34,8 +34,10 @@ public abstract class ECOracle {
      * secret was guessed correctly.
      * 
      * @param ecPoint
+     *            The Point
      * @param guessedSecret
-     * @return
+     *            The guessed Secret
+     * @return True if the secret is guessed correctly
      */
     public abstract boolean checkSecretCorrectnes(Point ecPoint, BigInteger guessedSecret);
 
@@ -45,7 +47,8 @@ public abstract class ECOracle {
      * correct.
      * 
      * @param guessedSecret
-     * @return
+     *            The guessed Secret
+     * @return True if the Solution is correct
      */
     public abstract boolean isFinalSolutionCorrect(BigInteger guessedSecret);
 

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/impl/Attacker.java

@@ -23,6 +23,7 @@
 
 /**
  * @param <Config>
+ *            The AttackConfig
  */
 public abstract class Attacker<Config extends AttackConfig> {
 

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/impl/PskBruteForcerAttackClient.java

@@ -46,10 +46,6 @@
 import de.rub.nds.tlsattacker.core.workflow.factory.WorkflowTraceType;
 import java.security.NoSuchAlgorithmException;
 
-/**
- *
- * @author florian
- */
 public class PskBruteForcerAttackClient extends Attacker<PskBruteForcerAttackClientCommandConfig> {
     private static final Logger LOGGER = LogManager.getLogger(PskBruteForcerAttackClient.class);
     private ServerTcpTransportHandler transportHandler;

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/impl/PskBruteForcerAttackServer.java

@@ -45,10 +45,6 @@
 import java.io.IOException;
 import java.io.InputStreamReader;
 
-/**
- *
- * @author florian
- */
 public class PskBruteForcerAttackServer extends Attacker<PskBruteForcerAttackServerCommandConfig> {
     private static final Logger LOGGER = LogManager.getLogger(PskBruteForcerAttackServer.class);
 

Attacks/src/main/java/de/rub/nds/tlsattacker/attacks/impl/TooManyAlgorithmsAttacker.java

@@ -23,10 +23,6 @@
 import java.util.List;
 import java.util.Random;
 
-/**
- *
- * @author Robert Merget <robert.merget@rub.de>
- */
 public class TooManyAlgorithmsAttacker extends Attacker<TooManyAlgorithmsAttackConfig> {
 
     public TooManyAlgorithmsAttacker(TooManyAlgorithmsAttackConfig config) {