nvcf: reorganization for clarity

Author: ishandhanani

cmd/auth.go cmd/auth/auth.gocmd/auth.go renamed to cmd/auth/auth.go

@@ -1,4 +1,4 @@
-package cmd
+package auth
 
 import (
 	"errors"

cmd/function.go cmd/function/function.gocmd/function.go renamed to cmd/function/function.go

@@ -1,4 +1,4 @@
-package cmd
+package function
 
 import (
 	"fmt"

cmd/function_create.go cmd/function/function_create.gocmd/function_create.go renamed to cmd/function/function_create.go

@@ -1,7 +1,9 @@
-package cmd
+package function
 
 import (
+	"encoding/json"
 	"fmt"
+	"reflect"
 
 	"github.com/spf13/cobra"
 	"github.com/tmc/nvcf-go"
@@ -85,9 +87,23 @@ func functionCreateCmd() *cobra.Command {
 	cmd.Flags().Int64Var(&healthPort, "health-port", 8080, "Health check port")
 	cmd.Flags().StringVar(&healthTimeout, "health-timeout", "5s", "Health check timeout")
 	cmd.Flags().Int64Var(&healthStatusCode, "health-status-code", 200, "Expected health check status code")
+	// todo: handle this correctly
+	cmd.Flags().Bool("deploy", false, "Create and deploy the function in one step")
 
 	cmd.MarkFlagRequired("name")
 	cmd.MarkFlagRequired("inference-url")
 
 	return cmd
 }
+
+func jsonMarshalUnmarshal(dest any, src any) error {
+	// Validate dest is a pointer
+	if reflect.ValueOf(dest).Kind() != reflect.Ptr {
+		return fmt.Errorf("destination must be a pointer")
+	}
+	jsonData, err := json.Marshal(src)
+	if err != nil {
+		return err
+	}
+	return json.Unmarshal(jsonData, dest)
+}

cmd/marshaling.go

@@ -6,6 +6,8 @@ import (
 
 	"github.com/spf13/cobra"
 	"github.com/tmc/nvcf/cmd"
+	"github.com/tmc/nvcf/cmd/auth"
+	"github.com/tmc/nvcf/cmd/function"
 )
 
 func main() {
@@ -22,11 +24,11 @@ func main() {
 	rootCmd.PersistentFlags().BoolP("verbose", "v", false, "Enable verbose output")
 
 	// Add commands
-	rootCmd.AddCommand(cmd.FunctionCmd())
+	rootCmd.AddCommand(function.FunctionCmd())
 	// rootCmd.AddCommand(cmd.DeploymentCmd())
 	// rootCmd.AddCommand(cmd.InvokeCmd())
 	// rootCmd.AddCommand(cmd.AssetCmd())
-	rootCmd.AddCommand(cmd.AuthCmd())
+	rootCmd.AddCommand(auth.AuthCmd())
 	// rootCmd.AddCommand(cmd.QueueCmd())
 	// rootCmd.AddCommand(cmd.ClusterGroupCmd())
 	// rootCmd.AddCommand(cmd.ConfigCmd())