Skip to content

Commit 8b58723

Browse files
committed
Remove bool arguments
1 parent f00e549 commit 8b58723

File tree

2 files changed

+31
-9
lines changed

2 files changed

+31
-9
lines changed

src/Factory/ToolFactory.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,22 @@ public static function createTool($name, $directory, array $parameters)
2727

2828
$parameters = array_merge($defaults, $parameters);
2929

30-
return new Tool(
30+
$tool = new Tool(
3131
$name,
3232
self::getFilename($name, $directory),
3333
$parameters['url'],
34-
$parameters['sign-url'],
35-
$parameters['force-replace'],
36-
$parameters['only-dev']
34+
$parameters['sign-url']
3735
);
36+
37+
if (true === $parameters['force-replace']) {
38+
$tool->activateForceReplace();
39+
}
40+
41+
if (false === $parameters['only-dev']) {
42+
$tool->disableOnlyDev();
43+
}
44+
45+
return $tool;
3846
}
3947

4048
/**

src/Model/Tool.php

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,31 @@ class Tool
4242
* @param string $filename
4343
* @param string $url
4444
* @param string $signUrl
45-
* @param bool $forceReplace
46-
* @param bool $onlyDev
45+
*
46+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
4747
*/
48-
public function __construct($name, $filename, $url, $signUrl = null, $forceReplace = false, $onlyDev = true)
48+
public function __construct($name, $filename, $url, $signUrl = null)
4949
{
5050
$this->name = $name;
5151
$this->filename = $filename;
5252
$this->url = $url;
5353
$this->signUrl = $signUrl;
54-
$this->forceReplace = $forceReplace;
55-
$this->onlyDev = $onlyDev;
54+
}
55+
56+
/**
57+
* @return void
58+
*/
59+
public function activateForceReplace()
60+
{
61+
$this->forceReplace = true;
62+
}
63+
64+
/**
65+
* @return void
66+
*/
67+
public function disableOnlyDev()
68+
{
69+
$this->onlyDev = false;
5670
}
5771

5872
/**

0 commit comments

Comments
 (0)