Add phpmd checks and add bz2 PHP extension for it

Author: tommy-muehle

.docker/php-5.6/Dockerfile

@@ -1,10 +1,7 @@
 FROM php:5.6-alpine
-
-# Uncomment the furhter line to add needed extension(s)
-# RUN docker-php-ext-install iconv
-
-# Uncomment the furhter line to add and enable a needed pecl extension(s)
-# RUN pecl install memcached && docker-php-ext-enable memcached
-
+RUN apk --update add libbz2 bzip2-dev && \
+    apk del build-base && \
+    rm -rf /var/cache/apk/*
+RUN docker-php-ext-install bz2
 VOLUME ["/app"]
 WORKDIR /app

.docker/php-7.0/Dockerfile

@@ -1,10 +1,7 @@
 FROM php:7.0-alpine
-
-# Uncomment the furhter line to add needed extension(s)
-# RUN docker-php-ext-install iconv
-
-# Uncomment the furhter line to add and enable a needed pecl extension(s)
-# RUN pecl install memcached && docker-php-ext-enable memcached
-
+RUN apk --update add libbz2 bzip2-dev && \
+    apk del build-base && \
+    rm -rf /var/cache/apk/*
+RUN docker-php-ext-install bz2
 VOLUME ["/app"]
 WORKDIR /app

.docker/php-7.1/Dockerfile

@@ -1,10 +1,7 @@
 FROM php:7.1-alpine
-
-# Uncomment the furhter line to add needed extension(s)
-# RUN docker-php-ext-install iconv
-
-# Uncomment the furhter line to add and enable a needed pecl extension(s)
-# RUN pecl install memcached && docker-php-ext-enable memcached
-
+RUN apk --update add libbz2 bzip2-dev && \
+    apk del build-base && \
+    rm -rf /var/cache/apk/*
+RUN docker-php-ext-install bz2
 VOLUME ["/app"]
 WORKDIR /app

.docker/run.sh

@@ -60,6 +60,9 @@ do
         print_task "Check PSR2 codestyle"
         execute "docker-compose run $VERSION php bin/phpcs.phar --standard=PSR2 ./src -v"
 
+        print_task "Check phpmd rules"
+        execute "docker-compose run $VERSION php bin/phpmd.phar ./src text ./phpmd.xml "
+
         print_task "Run copy paste detection"
         execute "docker-compose run $VERSION php bin/phpcpd.phar ./src"
     fi

.travis.yml

@@ -25,6 +25,7 @@ script:
   - ./bin/phpcs.phar --standard=PSR2 ./src -v
   - ./bin/phpcpd.phar ./src
   - ./bin/security-checker.phar security:check ./composer.lock
+  - ./bin/phpmd.phar ./src text ./phpmd.xml
   - ./bin/phpunit.phar --coverage-clover build/logs/clover.xml
 after_success:
   - ./bin/test-reporter

phpmd.xml

@@ -0,0 +1,57 @@
+<ruleset name="basic-rules"
+         xmlns="http://pmd.sf.net/ruleset/1.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0
+                      http://pmd.sf.net/ruleset_xml_schema.xsd"
+         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
+    <description>mess detection</description>
+
+    <rule ref="rulesets/cleancode.xml" />
+    <rule ref="rulesets/codesize.xml">
+        <exclude name="ExcessiveParameterList" />
+        <exclude name="ExcessiveMethodLength" />
+        <exclude name="ExcessiveClassLength" />
+        <exclude name="CyclomaticComplexity" />
+    </rule>
+    <rule ref="rulesets/codesize.xml/ExcessiveParameterList">
+        <properties>
+            <property name="minimum" value="4" />
+        </properties>
+    </rule>
+    <rule ref="rulesets/codesize.xml/ExcessiveMethodLength">
+        <properties>
+            <property name="minimum" value="31" />
+            <property name="ignore-whitespace" value="true" />
+        </properties>
+    </rule>
+    <rule ref="rulesets/codesize.xml/ExcessiveClassLength">
+        <properties>
+            <property name="minimum" value="301" />
+            <property name="ignore-whitespace" value="true" />
+        </properties>
+    </rule>
+    <rule ref="rulesets/codesize.xml/CyclomaticComplexity">
+        <properties>
+            <property name="reportLevel" value="6" />
+            <property name="showClassesComplexity" value="true" />
+            <property name="showMethodsComplexity" value="true" />
+        </properties>
+    </rule>
+    <rule ref="rulesets/controversial.xml" />
+    <rule ref="rulesets/design.xml" />
+    <rule ref="rulesets/naming.xml">
+        <exclude name="ShortVariable" />
+        <exclude name="LongVariable" />
+    </rule>
+    <rule ref="rulesets/naming.xml/ShortVariable">
+        <properties>
+            <property name="minimum" value="2" />
+        </properties>
+    </rule>
+    <rule ref="rulesets/naming.xml/LongVariable">
+        <properties>
+            <property name="maximum" value="30" />
+        </properties>
+    </rule>
+    <rule ref="rulesets/unusedcode.xml" />
+</ruleset>