Skip to content

Commit 99b16fa

Browse files
author
Tom Schlick
committed
better link header
1 parent 073235e commit 99b16fa

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/Http2ServerPushMiddleware.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace TomSchlick\ServerPush;
44

55
use Closure;
6-
use Illuminate\Support\Facades\Request;
6+
use Illuminate\Http\Request;
77

88
/**
99
* Class Http2ServerPushMiddleware
@@ -31,7 +31,8 @@ public function handle(Request $request, Closure $next)
3131

3232
protected function addServerPushHeaders()
3333
{
34-
foreach (app('server-push')->generateLinks() as $link) {
34+
if(app('server-push')->hasLinks()) {
35+
$link = implode(',', app('server-push')->generateLinks());
3536
$this->response->headers->set('Link', $link, true);
3637
}
3738
}

src/HttpPush.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,14 @@ public function generateLinks() : array
4545
return $links;
4646
}
4747

48+
/**
49+
* @return bool
50+
*/
51+
public function hasLinks() : bool
52+
{
53+
return !empty($this->resources);
54+
}
55+
4856
/**
4957
* Clear all resources out of the queue.
5058
*/

0 commit comments

Comments
 (0)