Skip to content

Drop package-lock.json and upgrade support to Node 10 to 16 #5

@mtrimolet

Description

@mtrimolet

Is the support for node v8 still wanted though ? I see @types/node@12 being installed, and it prevents upgrading eslint, typescript, ...

Support for node v8 could be safely removed

I suppose we could upgrade CI to check from v10 (even v12 ?) through v17, and maybe specify engine versions requirement, matching the type used, in the package.json.

CI should be updated to test v10, v12, v14 and v16 (only LTS releases).

PS: even npm conflicts : package.lock is v2, so uses npm v7, which requires node >=10

The package-lock.json should be removed from the repo (and added to .gitignore) since it's not part of the published package. It will force contributors to have latest versions of dependencies instead of locked one (better match the npm i fastify-oapi behavior).

This also means we should replace npm ci by npm install in CI workflows

Originally posted by @SomaticIT in #4 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions