more config

Author: johnrjj

src/sdk/v4/NftSwapV4.ts

@@ -56,6 +56,8 @@ import addresses from './addresses.json';
 import {
   ORDERBOOK_API_ROOT_URL_PRODUCTION,
   postOrderToOrderbook,
+  searchOrderbook,
+  SearchOrdersParams,
 } from './orderbook';
 
 export enum SupportedChainIdsV4 {
@@ -580,7 +582,7 @@ class NftSwapV4 implements INftSwapV4 {
   };
 
   postOrder = (
-    signedOrder: SignedNftOrderV4 | SignedNftOrderV4Serialized,
+    signedOrder: SignedNftOrderV4,
     chainId: string,
     metadata?: Record<string, string>
   ) => {
@@ -589,7 +591,12 @@ class NftSwapV4 implements INftSwapV4 {
     });
   };
 
-  getOrdersByWallet = () => {};
+  getOrders = async (filters?: Partial<SearchOrdersParams>) => {
+    const orders = await searchOrderbook(filters, {
+      rootUrl: this.orderbookRootUrl,
+    });
+    return orders;
+  };
 }
 
 export { NftSwapV4 };

src/sdk/v4/orderbook.ts

@@ -5,11 +5,11 @@ import { serializeNftOrder } from './pure';
 
 export const ORDERBOOK_API_ROOT_URL_PRODUCTION = 'https://api.trader.xyz';
 
-interface OrderbookRequestOptions {
+export interface OrderbookRequestOptions {
   rootUrl: string;
 }
 
-interface PostOrderRequestPayload {
+export interface PostOrderRequestPayload {
   order: SignedNftOrderV4Serialized;
   chainId: string;
   metadata?: Record<string, string>;
@@ -28,9 +28,9 @@ export interface OrderDataPayload {
   metadata: Record<string, string> | null;
 }
 
-type PostOrderResponsePayload = OrderDataPayload;
+export type PostOrderResponsePayload = OrderDataPayload;
 
-interface SearchOrdersResponsePayload {
+export interface SearchOrdersResponsePayload {
   orders: Array<OrderDataPayload>;
 }
 
@@ -76,16 +76,23 @@ const postOrderToOrderbook = async (
   return orderPostResult;
 };
 
-interface SearchParams {
+export interface SearchOrdersParams {
+  erc20Token: string;
+  nftTokenId: string;
+  nftToken: string;
+  nftType: string;
+  chainId: string;
+  maker: string;
+  taker: string;
   nonce: string;
 }
 
 const searchOrderbook = async (
-  filters: Partial<SearchParams>,
+  filters?: Partial<SearchOrdersParams>,
   requestOptions?: Partial<OrderbookRequestOptions>,
   fetchFn: typeof unfetch = unfetch
 ): Promise<SearchOrdersResponsePayload> => {
-  const stringifiedQueryParams = stringify(filters);
+  const stringifiedQueryParams = stringify(filters ?? {});
 
   let rootUrl = requestOptions?.rootUrl ?? ORDERBOOK_API_ROOT_URL_PRODUCTION;
 

test/v4/orderbook.test.ts

@@ -51,6 +51,14 @@ const MAKER_ASSET: SwappableAsset = {
 };
 
 describe('NFTSwapV4', () => {
+  it('orderbook should return orders', async () => {
+    const orders = await nftSwapperMaker.getOrders();
+
+    console.log(orders.orders.length);
+
+    expect(orders.orders.length).toBeGreaterThan(0);
+  });
+
   it('v4 erc721 test with orderbook e2e', async () => {
     // NOTE(johnrjj) - Assumes USDC and DAI are already approved w/ the ExchangeProxy
 
@@ -70,15 +78,17 @@ describe('NFTSwapV4', () => {
       testMetadata
     );
 
+    console.log('createdOrder', createdOrder);
+
     expect(createdOrder.order.nonce).toEqual(v4Erc721Order.nonce);
 
     const orderSearch = await searchOrderbook({
       nonce: signedOrder.nonce.toString(),
     });
     const maybeOrder = first(orderSearch.orders);
 
-    expect((maybeOrder as any).order.nonce).toEqual(signedOrder.nonce);
-    expect((maybeOrder as any).metadata).toEqual(testMetadata);
+    expect(maybeOrder?.order.nonce).toEqual(signedOrder.nonce);
+    expect(maybeOrder?.metadata).toEqual(testMetadata);
 
     // const orderTofill = (maybeOrder as any).order as SignedNftOrderV4Serialized
     // const fillTx = await nftSwapperMaker.fillSignedOrder(orderTofill);