Skip to content

Commit 6c3c6d6

Browse files
committed
comment tests
1 parent 589f1ed commit 6c3c6d6

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

test/v4/orderbook.test.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ describe('NFTSwapV4', () => {
9494
});
9595

9696
it('v4 orderbook rejects invalid order (maker token address on non-existant token)', async () => {
97-
// NOTE(johnrjj) - Assumes USDC and DAI are already approved w/ the ExchangeProxy
9897
const invalidOrder = nftSwapperMaker.buildOrder(
9998
// Has 'invalid' erc721 token address
10099
{
@@ -127,13 +126,8 @@ describe('NFTSwapV4', () => {
127126
});
128127

129128
it('v4 orderbook rejects invalid order (signature invalid)', async () => {
130-
// NOTE(johnrjj) - Assumes USDC and DAI are already approved w/ the ExchangeProxy
131129
const validOrder = nftSwapperMaker.buildOrder(
132-
// Has 'invalid' erc721 token address
133-
{
134-
...MAKER_ASSET,
135-
tokenAddress: '0x5Af0D9827E0c53E4799BB226655A1de152A425a5',
136-
},
130+
MAKER_ASSET,
137131
TAKER_ASSET,
138132
MAKER_WALLET_ADDRESS
139133
);
@@ -164,14 +158,12 @@ describe('NFTSwapV4', () => {
164158
});
165159

166160
it('v4 orderbook rejects invalid order (order expired)', async () => {
167-
// NOTE(johnrjj) - Assumes USDC and DAI are already approved w/ the ExchangeProxy
168161
const expiredOrder = nftSwapperMaker.buildOrder(
169-
// Has 'invalid' erc721 token address
170162
MAKER_ASSET,
171163
TAKER_ASSET,
172164
MAKER_WALLET_ADDRESS,
173165
{
174-
// Make expire yesterday
166+
// Make order expire yesterday
175167
expiry: getUnixTime(sub(new Date(), { days: 1 })),
176168
}
177169
);

0 commit comments

Comments
 (0)