Skip to content

Commit 6d3ab43

Browse files
committed
more type specificity
1 parent 34f03c0 commit 6d3ab43

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/sdk/v4/NftSwapV4.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ import type {
4242
ApprovalOverrides,
4343
FillOrderOverrides,
4444
NftOrderV4,
45+
NftOrderV4Serialized,
4546
OrderStructOptionsCommonStrict,
4647
SignedNftOrderV4,
4748
SigningOptions,
@@ -71,7 +72,7 @@ export interface INftSwapV4 extends BaseNftSwap {
7172
sellOrBuyNft: 'sell' | 'buy',
7273
makerAddress: string,
7374
userConfig?: Partial<OrderStructOptionsCommonStrict>
74-
) => NftOrderV4;
75+
) => NftOrderV4Serialized;
7576
loadApprovalStatus: (
7677
asset: SwappableAsset,
7778
walletAddress: string,
@@ -225,25 +226,25 @@ class NftSwapV4 implements INftSwapV4 {
225226
takerAsset: UserFacingERC20AssetDataSerialized,
226227
makerAddress: string,
227228
orderConfig?: Partial<OrderStructOptionsCommonStrict>
228-
): NftOrderV4;
229+
): NftOrderV4Serialized;
229230
buildOrder(
230231
makerAsset: UserFacingERC20AssetDataSerialized,
231232
takerAsset: UserFacingERC1155AssetDataSerializedNormalizedSingle,
232233
makerAddress: string,
233234
orderConfig?: Partial<OrderStructOptionsCommonStrict>
234-
): NftOrderV4;
235+
): NftOrderV4Serialized;
235236
buildOrder(
236237
makerAsset: UserFacingERC721AssetDataSerialized,
237238
takerAsset: UserFacingERC20AssetDataSerialized,
238239
makerAddress: string,
239240
orderConfig?: Partial<OrderStructOptionsCommonStrict>
240-
): NftOrderV4;
241+
): NftOrderV4Serialized;
241242
buildOrder(
242243
makerAsset: UserFacingERC20AssetDataSerialized,
243244
takerAsset: UserFacingERC721AssetDataSerialized,
244245
makerAddress: string,
245246
orderConfig?: Partial<OrderStructOptionsCommonStrict>
246-
): NftOrderV4;
247+
): NftOrderV4Serialized;
247248
buildOrder(
248249
makerAsset: SwappableAsset,
249250
takerAsset: SwappableAsset,
@@ -299,7 +300,7 @@ class NftSwapV4 implements INftSwapV4 {
299300
type: 'ERC721' | 'ERC1155';
300301
},
301302
makerAddress: string
302-
) => {
303+
): NftOrderV4Serialized => {
303304
return this.buildNftAndErc20Order(
304305
{
305306
...nftCollectionToBid,
@@ -322,7 +323,7 @@ class NftSwapV4 implements INftSwapV4 {
322323
sellOrBuyNft: 'sell' | 'buy' = 'sell',
323324
makerAddress: string,
324325
userConfig?: Partial<OrderStructOptionsCommonStrict>
325-
): NftOrderV4 => {
326+
): NftOrderV4Serialized => {
326327
const defaultConfig = { chainId: this.chainId, makerAddress: makerAddress };
327328
const config = { ...defaultConfig, ...userConfig };
328329

0 commit comments

Comments
 (0)