Scaffold util functionos + better handling of buying nft with eth

Author: johnrjj

src/sdk/v4/NftSwapV4.ts

@@ -57,6 +57,7 @@ import {
 import { DIRECTION_MAPPING, OrderStatusV4, TradeDirection } from './enums';
 import { CONTRACT_ORDER_VALIDATOR } from './properties';
 import { getWrappedNativeToken } from '../../utils/addresses';
+import { ETH_ADDRESS_AS_ERC20 } from './constants';
 
 export enum SupportedChainIdsV4 {
   Mainnet = 1,
@@ -199,19 +200,19 @@ class NftSwapV4 implements INftSwapV4 {
     );
   }
 
-  loadApprovalStatus = (
+  loadApprovalStatus(
     asset: SwappableAssetV4,
     walletAddress: string,
     approvalOverrides?: Partial<ApprovalOverrides> | undefined
-  ) => {
+  ): Promise<ApprovalStatus> {
     // TODO(johnrjj) - Fix to pass thru more args...
     return getApprovalStatus(
       walletAddress,
       approvalOverrides?.exchangeContractAddress ?? this.exchangeProxy.address,
       asset,
       this.provider
     );
-  };
+  }
 
   awaitTransactionHash = async (txHash: string) => {
     return this.provider.waitForTransaction(txHash);
@@ -562,12 +563,18 @@ class NftSwapV4 implements INftSwapV4 {
     if ('erc1155Token' in signedOrder) {
       // If maker is selling an NFT, taker wants to 'buy' nft
       if (signedOrder.direction === TradeDirection.SellNFT) {
+        const needsEthAttached =
+          signedOrder.erc20Token.toLowerCase() === ETH_ADDRESS_AS_ERC20;
+
         return this.exchangeProxy.buyERC1155(
           signedOrder,
           signedOrder.signature,
           signedOrder.erc1155TokenAmount,
           '0x',
-          transactionOverrides ?? {}
+          {
+            value: needsEthAttached ? signedOrder.erc20TokenAmount : undefined,
+            ...transactionOverrides,
+          }
         );
       } else {
         // TODO(detect if erc20 token is wrapped token, then switch true. if true when not wrapped token, tx will fail)
@@ -595,17 +602,26 @@ class NftSwapV4 implements INftSwapV4 {
           signedOrder.erc1155TokenAmount,
           unwrapNativeToken,
           '0x',
-          transactionOverrides ?? {}
+          {
+            ...transactionOverrides,
+          }
         );
       }
     } else if ('erc721Token' in signedOrder) {
       // If maker is selling an NFT, taker wants to 'buy' nft
+
       if (signedOrder.direction === TradeDirection.SellNFT) {
+        const needsEthAttached =
+          signedOrder.erc20Token.toLowerCase() === ETH_ADDRESS_AS_ERC20;
+
         return this.exchangeProxy.buyERC721(
           signedOrder,
           signedOrder.signature,
           '0x',
-          transactionOverrides ?? {}
+          {
+            value: needsEthAttached ? signedOrder.erc20TokenAmount : undefined,
+            ...transactionOverrides,
+          }
         );
       } else {
         // TODO(detect if erc20 token is wrapped token, then switch true. if true when not wrapped token, tx will fail)
@@ -631,7 +647,10 @@ class NftSwapV4 implements INftSwapV4 {
           fillOrderOverrides?.tokenIdToSellForCollectionOrder ??
             signedOrder.erc721TokenId,
           unwrapNativeToken,
-          '0x'
+          '0x',
+          {
+            ...transactionOverrides,
+          }
         );
       }
     }
@@ -684,6 +703,51 @@ class NftSwapV4 implements INftSwapV4 {
       'Only ERC721 Orders are currently supported for matching. Please ensure both the sellOrder and buyOrder are ERC721 orders'
     );
   };
+
+  getTakerAsset = (order: NftOrderV4): SwappableAssetV4 => {
+    // return {
+    //   tokenAddress: '',
+    //   tokenId: ''
+    // }
+  };
+
+  getMakerAsset = (order: NftOrderV4): SwappableAssetV4 => {
+    // return {
+    //   tokenAddress: '',
+    //   tokenId: ''
+    // }
+  };
+
+  // todo: consolidate
+  // todo: use these to power validation for the api
+  checkOrderCanBeFilledMakerSide = (order: NftOrderV4) => {};
+
+  checkOrderCanBeFilledTakerSide = (
+    order: NftOrderV4,
+    override?: VerifyOrderOptionsOverrides
+  ) => {
+    const shouldLoadApprovalStatus = override?.verifyApproval ?? true;
+    const shouldLoadBalance = override?.verifyBalance ?? true;
+
+    const direction = parseInt(order.direction.toString(10));
+    if (direction === TradeDirection.SellNFT) {
+      if ('erc721Token' in order) {
+        this.loadApprovalStatus();
+
+        const { erc721Token, erc721TokenId } = order;
+
+        // TODO(johnrjj) - More validation here before we match on-chain
+      } else if ('erc1155Token' in order) {
+        const { erc1155TokenAmount, erc1155Token, erc1155TokenId } = order;
+      }
+    } else if (direction === TradeDirection.BuyNFT) {
+    }
+  };
+}
+
+interface VerifyOrderOptionsOverrides {
+  verifyApproval?: boolean;
+  verifyBalance: boolean;
 }
 
 export { NftSwapV4 };