Skip to content

Commit b5fc575

Browse files
committed
updated deployment, better errors
1 parent be68723 commit b5fc575

File tree

4 files changed

+19
-1
lines changed

4 files changed

+19
-1
lines changed

deploy/deployment.yaml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,22 @@ spec:
1818
- name: freenas-iscsi-provisioner
1919
image: docker.io/travisghansen/freenas-iscsi-provisioner:latest
2020
env:
21+
# when running multiple instances each pod should have a unique identifier
2122
#- name: IDENTIFIER
22-
# value:
23+
# valueFrom:
24+
# fieldRef:
25+
# fieldPath: metadata.name
2326
#- name: PROVISIONER_NAME
2427
# value:
28+
#- name: CONTROLLER_THREADINESS
29+
# value: "4"
30+
#- name: CONTROLLER_CREATE_PROVISIONED_PV_INTERVAL
31+
# value: "10"
32+
#- name: CONTROLLER_LEASE_DURATION
33+
# value: "15"
34+
#- name: CONTROLLER_RENEW_DEADLINE
35+
# value: "10"
36+
#- name: CONTROLLER_RETRY_PERIOD
37+
# value: "2"
38+
39+

freenas/extent.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ func (e *Extent) Delete(server *Server) (*http.Response, error) {
133133
resp, err := server.getSlingConnection().Delete(endpoint).Receive(nil, &es)
134134
if err != nil {
135135
glog.Warningln(err)
136+
return resp, err
136137
}
137138

138139
if resp.StatusCode != 204 {

freenas/target.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ func (t *Target) Delete(server *Server) (*http.Response, error) {
124124
resp, err := server.getSlingConnection().Delete(endpoint).Receive(nil, &e)
125125
if err != nil {
126126
glog.Warningln(err)
127+
return resp, err
127128
}
128129

129130
if resp.StatusCode != 204 {

freenas/zvol.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ func (z *Zvol) Delete(server *Server) (*http.Response, error) {
100100
resp, err := server.getSlingConnection().Delete(endpoint).BodyJSON(b).Receive(nil, &e)
101101
if err != nil {
102102
glog.Warningln(err)
103+
return resp, err
103104
}
104105

105106
if resp.StatusCode != 204 {

0 commit comments

Comments
 (0)