Skip to content

Commit 0696cf5

Browse files
committed
Memory tab improvement
Add max, avg & min values in addition to current values. This can make it easier to identify if a memory clerk had high or low usage within the selected date range. Added column descriptions.
1 parent 9205932 commit 0696cf5

File tree

2 files changed

+140
-47
lines changed

2 files changed

+140
-47
lines changed

DBADashDB/dbo/Stored Procedures/MemoryUsage_Get.sql

Lines changed: 47 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,65 @@ FROM dbo.MemoryUsage MU
1818
WHERE MU.InstanceID = @InstanceID
1919
AND MU.SnapshotDate>=@FromDate
2020
AND MU.SnapshotDate < @ToDate
21-
ORDER BY MU.SnapshotDate DESC
21+
ORDER BY MU.SnapshotDate DESC;
2222

23+
WITH Agg AS (
24+
SELECT MemoryClerkTypeID,
25+
MAX(pages_kb) AS max_pages_kb,
26+
AVG(pages_kb) AS avg_pages_kb,
27+
MIN(pages_kb) AS min_pages_kb,
28+
MAX(virtual_memory_reserved_kb) AS max_virtual_memory_reserved_kb,
29+
AVG(virtual_memory_reserved_kb) AS avg_virtual_memory_reserved_kb,
30+
MIN(virtual_memory_reserved_kb) AS min_virtual_memory_reserved_kb,
31+
MAX(virtual_memory_committed_kb) AS max_virtual_memory_committed_kb,
32+
AVG(virtual_memory_committed_kb) AS avg_virtual_memory_committed_kb,
33+
MIN(virtual_memory_committed_kb) AS min_virtual_memory_committed_kb,
34+
MAX(awe_allocated_kb) AS max_awe_allocated_kb,
35+
AVG(awe_allocated_kb) AS avg_awe_allocated_kb,
36+
MIN(awe_allocated_kb) AS min_awe_allocated_kb,
37+
MAX(shared_memory_reserved_kb) AS max_shared_memory_reserved_kb,
38+
AVG(shared_memory_reserved_kb) AS avg_shared_memory_reserved_kb,
39+
MIN(shared_memory_reserved_kb) AS min_shared_memory_reserved_kb,
40+
MAX(shared_memory_committed_kb) AS max_shared_memory_committed_kb,
41+
AVG(shared_memory_committed_kb) AS avg_shared_memory_committed_kb,
42+
MIN(shared_memory_committed_kb) AS min_shared_memory_committed_kb
43+
FROM dbo.MemoryUsage
44+
WHERE InstanceID = @InstanceID
45+
AND SnapshotDate >= @FromDate
46+
AND SnapshotDate < @ToDate
47+
GROUP BY MemoryClerkTypeID
48+
)
2349
SELECT MCT.MemoryClerkType,
2450
ISNULL(MCT.MemoryClerkDescription,'Description not available.') AS MemoryClerkDescription,
2551
MU.pages_kb,
52+
Agg.max_pages_kb,
53+
Agg.avg_pages_kb,
54+
Agg.min_pages_kb,
2655
MU.virtual_memory_reserved_kb,
56+
Agg.max_virtual_memory_reserved_kb,
57+
Agg.avg_virtual_memory_reserved_kb,
58+
Agg.min_virtual_memory_reserved_kb,
2759
MU.virtual_memory_committed_kb,
60+
Agg.max_virtual_memory_committed_kb,
61+
Agg.avg_virtual_memory_committed_kb,
62+
Agg.min_virtual_memory_committed_kb,
2863
MU.awe_allocated_kb,
64+
Agg.max_awe_allocated_kb,
65+
Agg.avg_awe_allocated_kb,
66+
Agg.min_awe_allocated_kb,
2967
MU.shared_memory_reserved_kb,
68+
Agg.max_shared_memory_reserved_kb,
69+
Agg.avg_shared_memory_reserved_kb,
70+
Agg.min_shared_memory_reserved_kb,
3071
MU.shared_memory_committed_kb,
72+
Agg.max_shared_memory_committed_kb,
73+
Agg.avg_shared_memory_committed_kb,
74+
Agg.min_shared_memory_committed_kb,
3175
MU.SnapshotDate,
3276
MU.pages_kb*1.0 / SUM(MU.pages_kb) OVER() AS Pct
3377
FROM dbo.MemoryUsage MU
34-
JOIN dbo.MemoryClerkType MCT
35-
ON MCT.MemoryClerkTypeID = MU.MemoryClerkTypeID
78+
JOIN dbo.MemoryClerkType MCT ON MCT.MemoryClerkTypeID = MU.MemoryClerkTypeID
79+
JOIN Agg ON Agg.MemoryClerkTypeID = MU.MemoryClerkTypeID
3680
WHERE MU.InstanceID = @InstanceID
3781
AND MU.SnapshotDate = @LatestSnapshot
3882
ORDER BY MU.pages_kb DESC

0 commit comments

Comments
 (0)