Skip to content

Commit 9205932

Browse files
committed
Waits tab - Add option to show bar chart
Add option to show waits bar chart (previously available only on the performance tab). Bar chart can be toggled on/off and wait line chart can now be closed after opening.
1 parent ac97a9b commit 9205932

File tree

7 files changed

+279
-148
lines changed

7 files changed

+279
-148
lines changed

DBADashGUI/Performance/WaitsSummary.Designer.cs

Lines changed: 128 additions & 57 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

DBADashGUI/Performance/WaitsSummary.cs

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ public WaitsSummary()
1515
{
1616
InitializeComponent();
1717
dgv.RegisterClearFilter(tsClearFilter);
18+
waits1.CloseVisible = true;
19+
splitGrid.Panel1Collapsed = true;
1820
}
1921

2022
private int InstanceID { get; set; }
@@ -146,14 +148,20 @@ private void TsMetrics_Click(object sender, EventArgs e)
146148

147149
private void RefreshChart()
148150
{
149-
if (string.IsNullOrEmpty(selectedWaitType))
151+
if (splitGrid.Panel1Collapsed && string.IsNullOrEmpty(selectedWaitType))
150152
{
151-
splitContainer1.Panel1Collapsed = true;
153+
return;
152154
}
153-
else
155+
splitChart.Panel1Collapsed = string.IsNullOrEmpty(selectedWaitType);
156+
157+
if (!splitChart.Panel2Collapsed)
158+
{
159+
waits1.RefreshData(InstanceID);
160+
}
161+
if (!splitChart.Panel1Collapsed)
154162
{
155163
tsWaitType.Text = selectedWaitType;
156-
splitContainer1.Panel1Collapsed = false;
164+
splitGrid.Panel1Collapsed = false;
157165
var dt = GetWaitsDT(selectedWaitType);
158166
WaitChart1.LegendLocation = LiveCharts.LegendLocation.Bottom;
159167
WaitChart1.Series.Clear();
@@ -225,5 +233,19 @@ private void TsExcel_Click(object sender, EventArgs e)
225233
{
226234
dgv.ExportToExcel();
227235
}
236+
237+
private void ToggleBarChart_Click(object sender, EventArgs e)
238+
{
239+
splitChart.Panel2Collapsed = !splitChart.Panel2Collapsed;
240+
splitGrid.Panel1Collapsed = splitChart.Panel2Collapsed && string.IsNullOrEmpty(selectedWaitType);
241+
RefreshChart();
242+
}
243+
244+
private void CloseLineChart_Click(object sender, EventArgs e)
245+
{
246+
selectedWaitType = string.Empty;
247+
splitGrid.Panel1Collapsed = splitChart.Panel2Collapsed;
248+
RefreshChart();
249+
}
228250
}
229251
}

DBADashGUI/Performance/WaitsSummary.resx

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,4 +159,16 @@
159159
<metadata name="toolStrip2.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
160160
<value>141, 17</value>
161161
</metadata>
162+
<assembly alias="System.Drawing" name="System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
163+
<data name="tsBar.Image" type="System.Drawing.Bitmap, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
164+
<value>
165+
iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8
166+
YQUAAAAJcEhZcwAAEnQAABJ0Ad5mH3gAAAEBSURBVEhL3ZIvC8JAGIf3OTTZ/A62+RXs2g2rFsGi2P0C
167+
WlwT02wGMQjLhgVRnAMR/5bVV37CHeduf9TdFQfPDt7wPOy9GWEYkk4MvGzbJsuylAInD2BgmqZS4JQC
168+
99tDCcoCl+OBPKdH3qxHe3eiPuAOTFq0CxwWURYQ5QBfojfgKA5sl0Mux7pwJx8H/NOdmvPj64yKs8gM
169+
QFqdBlQc7V/nt5HUwDq4cTnj20hiYLW7Unnsv8l/icQGKrVGojwrgpk4lwL1VpdKw40kjCMaYfclzqVA
170+
3z1LojSYTPwZ2Bxrzh1gsujPALBmrDt3IA2sG2vXFgBw/lFAJwh0dGLofp4xWrfOyeSKuAAAAABJRU5E
171+
rkJggg==
172+
</value>
173+
</data>
162174
</root>

DBADashGUI/Properties/Resources.Designer.cs

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)