fix save_to_trubrics in FeedbackCollector

Author: jeffkayne

CHANGELOG.md

@@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Fixed
 - `user_response` is dict rather than `Response` for feedback_type="text"
+- `collector.st_feedback(..., save_to_trubrics=False)` returns a python dict
+- pydantic dependency updated and `.dict()` updated to `.model_dump()`
 
 ## [1.5.1] - 2023-08-29
 ### Changed

requirements.txt

@@ -1,4 +1,4 @@
 requests>=2.28.0
-pydantic>=1.9.1
+pydantic>=2.0.0
 typer>=0.6.1
 loguru>=0.6.0

trubrics/integrations/streamlit/collect.py

@@ -4,6 +4,7 @@
 from streamlit_feedback import streamlit_feedback
 
 from trubrics import Trubrics
+from trubrics.platform.feedback import Feedback, Response
 
 
 class FeedbackCollector(Trubrics):
@@ -97,24 +98,37 @@ def st_feedback(
         else:
             raise ValueError("feedback_type must be one of ['textbox', 'faces', 'thumbs'].")
 
-        if user_response and save_to_trubrics:
-            feedback = self.log_feedback(
-                component=component,
-                user_response=user_response,
-                model=model,
-                prompt_id=prompt_id,
-                metadata=metadata,
-                tags=tags,
-                user_id=user_id,
-            )
-            if feedback is None:
-                error_msg = "Error in pushing feedback issue to Trubrics."
-                if success_fail_message:
-                    st.error(error_msg)
+        if user_response:
+            if save_to_trubrics:
+                feedback = self.log_feedback(
+                    component=component,
+                    user_response=user_response,
+                    model=model,
+                    prompt_id=prompt_id,
+                    metadata=metadata,
+                    tags=tags,
+                    user_id=user_id,
+                )
+                if feedback is None:
+                    error_msg = "Error in pushing feedback issue to Trubrics."
+                    if success_fail_message:
+                        st.error(error_msg)
+                else:
+                    if success_fail_message:
+                        st.success("Feedback saved to Trubrics.")
+                    return feedback.model_dump()
             else:
-                if success_fail_message:
-                    st.success("Feedback saved to Trubrics.")
-                return feedback.dict()
+                user_response = Response(**user_response)
+                feedback = Feedback(
+                    component=component,
+                    model=model,
+                    user_response=user_response,
+                    prompt_id=prompt_id,
+                    user_id=user_id,
+                    tags=tags,
+                    metadata=metadata,
+                )
+                return feedback.model_dump()
         return None
 
     @staticmethod