Do not delete the NS and let the user do it by himself

[carlosthe19916]

The following commit dfec951

Introduced the line kubectl delete namespace ${NAMESPACE} which fully deletes the namespace from a cluster. That is a dangerous thing to do and should be done by the user that executes our scripts.

[jcrossley3]

As you can tell from my comment in the commit, I didn't want to do it. But I feel strongly that the install script should be idempotent. It should install trustify whether another trustify is already installed in that ns or not.

But I don't know enough about the operator-sdk tool to make that work.

[carlosthe19916]

You made me think a lot about how Operator work.

But I feel strongly that the install script should be idempotent

It seems to me that installing an operator on top of a previously installed operator just for updating the version of the operator or containers is not how OLM is supposed to work.

I am not an expert but once an operator is installed, then any upgrade of the operator should be done by OLM. Reinstalling it goes against the OLM design itself.

But I am not an expert and until we find a better solution I think we can keep this issue open as one way or another we both agree that deleting the namespace is not the way to go. The question is how we upgrade the containers without deleting the namespaces.