fix: support imperial sizes for led and diode in string parser#618
Open
64johnlee wants to merge 2 commits into
Open
fix: support imperial sizes for led and diode in string parser#61864johnlee wants to merge 2 commits into
64johnlee wants to merge 2 commits into
Conversation
Issue tscircuit#562: String parser fails for led and diode with imperial sizes The proxy handler only recognized 'res' and 'cap' for imperial sizing. Added 'led' and 'diode' to the condition so led0402, diode0603 etc. now parse correctly instead of being treated as pin counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for issue #562: String parser fails for led and diode with imperial sizes (e.g., led0402, diode0603)
The proxy handler only recognized
resandcapfor imperial sizing. This change addsledanddiodeso they also parse correctly as<fn><imperial_size>instead of being treated as pin counts.Before:
fp.string("led0402").circuitJson()→ ErrorAfter:
fp.string("led0402").circuitJson()→ Works correctlyChange
src/footprinter.tsline 410: Addedledanddiodeto the imperial size conditionTesting
All 410 tests pass.