A couple of formatting/feature requests (and a thank you!)

[samueltlg]

Firstly, many thanks for the extension! I came across the need for this when destructuring objects with lots of properties - this can be quite a time-saver. Lots of good re-factorings here. I'm sure if more knew of it's usefulness it would be a more popular extension!

Regarding your comment on formatting requests in your (comprehensive) extension-documentation, I had a request. Would it be possible to have a setting to opt-out of printing semi-colons?
And another suggestion: a setting regarding whether to destructure optional properties, by default? And perhaps an option to destructure alphabetically rather than in interface/type definition order?

And finally, again regarding the destructuring refactor: perhaps an option to complete the destructuring for an incompletely-destructured, destructuring assignment, in-place? :

Thanks again!

[tusaeff]

Hi! Sorry about the long answer and thank you so much for the positive feedback! It's very encouraging.

About your proposals:

1. [setting to opt-out of printing semi-colons] Typescript already provides semicolon information among other editor settings - and these settings should definitely be supported when formatting, you're right.
2. [setting to (not) destructure optional properties] Hm, do you think that's gonna be a popular feature? In my experience, most of the time we destructure all the fields, but for the optional, we set default values
3. [destructure alphabetically] Same question as above.
4. [complete the destructuring for an incompletely-destructured ] Yes! I thought about it, but I haven't had time to implement

Thank you very much for your contribution!

[samueltlg]

Hi @tusaeff

No problem at all! It is a helpful clever extension.
I forked the repo earlier to scan through the codebase. It's quite nicely written! Seems to implement and work with a lot of interfaces and instances of tslib, naturally.

With regards to points number two and three. :

• You are correct with regards to needing to set default values when destructuring function (object) parameters, but when using the 'create destructuring assignment' or 'destructure object property' refactors, it is possible that you wish to destructure from an existing object of which you know (for that particular object) that the optional properties do not exist (on it), or only the required properties need to be used. I have come across a few instances where this would have been useful, so thought it might be a worthwhile suggestion. This one may be better as an additional refactoring
• Regarding destructuring alphabetically: a couple of reasons I suggest this. Firstly, when destructing an object with lots of properties (let's say 10+), and where you need to use approx. half of them, it can be handy to have them listed alphabetically so that it's possible to locate and delete the unused destructured properties more easily. Another reason is for keeping in line with linting rules; I know that some linters listing object/interface keys alphabetically is a rule, and that some programmers like to keep lists such as these alphabetical for readability etc, in any case. Having them printed in definition order can certainly be desirable too, so perhaps if this was implemented an additional refactor would be better (or maybe a setting would be fine too, otherwise too many refactorings may be introduced!).

Many thanks again!

[samueltlg]

Also, if destructuring optional parameters and destructuring alphabetically does not interest you or you see no use for it, I could try and eventually get round to implementing and making a pull-request? Looks like quite an interesting extension to work on in any case !