Skip to content

Commit 82cc2b2

Browse files
committed
add logs
1 parent f90cd8b commit 82cc2b2

File tree

3 files changed

+27
-6
lines changed

3 files changed

+27
-6
lines changed

pkg/controllers/gateway_controller.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ import (
2626

2727
"github.com/aws/aws-application-networking-k8s/pkg/aws"
2828
"github.com/aws/aws-application-networking-k8s/pkg/config"
29-
"github.com/aws/aws-application-networking-k8s/pkg/k8s"
3029
"github.com/aws/aws-application-networking-k8s/pkg/model/core"
3130
lattice_runtime "github.com/aws/aws-application-networking-k8s/pkg/runtime"
3231
"github.com/aws/aws-application-networking-k8s/pkg/utils"
3332
"github.com/aws/aws-application-networking-k8s/pkg/utils/gwlog"
3433

34+
"github.com/aws/aws-application-networking-k8s/pkg/k8s"
3535
"github.com/pkg/errors"
3636
corev1 "k8s.io/api/core/v1"
3737
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -72,14 +72,14 @@ func RegisterGatewayController(
7272
scheme := mgr.GetScheme()
7373
evtRec := mgr.GetEventRecorderFor("gateway")
7474

75-
ok, err := k8s.IsGVKSupported(mgr, gwv1.GroupVersion.String(), "GatewayClass")
75+
ok, err := k8s.IsGVKSupported(mgr, gwv1.GroupVersion.String(), "Gateway")
7676
if err != nil {
77-
log.Infof(context.TODO(), "Failed to check if GatewayClass is supported: %s", err.Error())
78-
return fmt.Errorf("failed to check if GatewayClass is supported: %w", err)
77+
log.Infof(context.TODO(), "Failed to check if Gateway is supported: %s", err.Error())
78+
return nil
7979
}
8080
if !ok {
81-
log.Infof(context.TODO(), "GatewayClass is not supported, skipping controller registration")
82-
return fmt.Errorf("GatewayClass is not supported, skipping controller registration")
81+
log.Infof(context.TODO(), "Gateway is not supported, skipping controller registration")
82+
return nil
8383
}
8484
r := &gatewayReconciler{
8585
log: log,

pkg/controllers/gatewayclass_controller.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"time"
2222

2323
"github.com/aws/aws-application-networking-k8s/pkg/config"
24+
"github.com/aws/aws-application-networking-k8s/pkg/k8s"
2425
"github.com/aws/aws-application-networking-k8s/pkg/utils/gwlog"
2526
"github.com/pkg/errors"
2627

@@ -45,6 +46,15 @@ func RegisterGatewayClassController(log gwlog.Logger, mgr ctrl.Manager) error {
4546
scheme: mgr.GetScheme(),
4647
latticeControllerEnabled: false,
4748
}
49+
ok, err := k8s.IsGVKSupported(mgr, gwv1.GroupVersion.String(), "GatewayClass")
50+
if err != nil {
51+
log.Infof(context.TODO(), "Failed to check if GatewayClass is supported: %s", err.Error())
52+
return nil
53+
}
54+
if !ok {
55+
log.Infof(context.TODO(), "GatewayClass is not supported, skipping controller registration")
56+
return nil
57+
}
4858
return ctrl.NewControllerManagedBy(mgr).
4959
For(&gwv1.GatewayClass{}).
5060
Complete(r)

pkg/controllers/route_controller.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ func RegisterAllRouteControllers(
8585
mgr ctrl.Manager,
8686
) error {
8787
mgrClient := mgr.GetClient()
88+
8889
gwEventHandler := eventhandlers.NewEnqueueRequestGatewayEvent(log, mgrClient)
8990
svcEventHandler := eventhandlers.NewServiceEventHandler(log, mgrClient)
9091

@@ -98,6 +99,16 @@ func RegisterAllRouteControllers(
9899
}
99100

100101
for _, routeInfo := range routeInfos {
102+
fmt.Println("groupVersion : ", routeInfo.gatewayApiType.GetObjectKind().GroupVersionKind().Group)
103+
fmt.Println("kind : ", routeInfo.gatewayApiType.GetObjectKind().GroupVersionKind().Kind)
104+
if ok, err := k8s.IsGVKSupported(mgr, routeInfo.gatewayApiType.GetObjectKind().GroupVersionKind().Group, routeInfo.gatewayApiType.GetObjectKind().GroupVersionKind().Kind); !ok {
105+
fmt.Printf("Route GroupKind %s is not supported, skipping controller registration\n", routeInfo.gatewayApiType.GetObjectKind().GroupVersionKind().Kind)
106+
107+
} else {
108+
if err != nil {
109+
return err
110+
}
111+
}
101112
brTgBuilder := gateway.NewBackendRefTargetGroupBuilder(log, mgrClient)
102113
reconciler := routeReconciler{
103114
routeType: routeInfo.routeType,

0 commit comments

Comments
 (0)