Skip to content

Commit 7c3a521

Browse files
authored
Make sure GitLabTestContextRequestOptions.LogHeaders() masks authent data (#523)
1 parent 0bcd2e8 commit 7c3a521

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

NGitLab.Tests/Docker/GitLabTestContextRequestOptions.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,13 +199,21 @@ private static void LogHeaders(StringBuilder sb, WebHeaderCollection headers)
199199

200200
foreach (var headerValue in headerValues)
201201
{
202+
sb.Append(headerName).Append(": ");
202203
if (string.Equals(headerName, "Private-Token", StringComparison.OrdinalIgnoreCase))
203204
{
204-
sb.Append("Private-Token").Append(": ****** ").AppendLine();
205+
sb.AppendLine("******");
206+
}
207+
else if (string.Equals(headerName, "Authorization", StringComparison.OrdinalIgnoreCase))
208+
{
209+
const string BearerTokenPrefix = "Bearer ";
210+
if (headerValue.StartsWith(BearerTokenPrefix, StringComparison.Ordinal))
211+
sb.Append(BearerTokenPrefix);
212+
sb.AppendLine("******");
205213
}
206214
else
207215
{
208-
sb.Append(headerName).Append(": ").Append(headerValue).AppendLine();
216+
sb.AppendLine(headerValue);
209217
}
210218
}
211219
}

0 commit comments

Comments
 (0)