fixing common errors

Author: Rishabh

src/Rating/components/IconBar.js

@@ -25,40 +25,25 @@ const IconBar = ({
   selectedIconImage,
   emptyIconImage,
   filled = false,
-}) => {
-  const emptyIcon = type === "custom" ? emptyIconImage : name;
-  const filledIcon = type === "custom" ? selectedIconImage : name;
-
-  return (
-    <TouchableOpacity
-      onPress={() => {
-        if (!readonly) {
-          onIconTap(position + 1);
-        }
-      }}
-    >
-      {type === "custom" ? (
-        <StyledImage
-          source={filled ? filledIcon : emptyIcon}
-          margin={margin}
-          size={size}
-        />
-      ) : (
-        <StyledIcon
-          onPress={() => {
-            if (!readonly) {
-              onIconTap(position + 1);
-            }
-          }}
-          name={name}
-          size={size}
-          color={color}
-          margin={margin}
-        />
-      )}
-    </TouchableOpacity>
-  );
-};
+}) => (
+  <TouchableOpacity
+    onPress={() => {
+      if (!readonly) {
+        onIconTap(position + 1);
+      }
+    }}
+  >
+    {type === "custom" ? (
+      <StyledImage
+        source={filled ? selectedIconImage : emptyIconImage}
+        margin={margin}
+        size={size}
+      />
+    ) : (
+      <StyledIcon name={name} size={size} color={color} margin={margin} />
+    )}
+  </TouchableOpacity>
+);
 
 IconBar.propTypes = {
   color: PropTypes.string,

src/Rating/index.js

@@ -51,9 +51,9 @@ const Rating = ({
         {Array.from({ length: totalCount }, (_, i) => (
           <IconBar
             name={icon}
+            key={`bgstar_${i}`}
             size={size}
             position={i}
-            key={`bgstar_${i}`}
             color={ratingBackgroundColor}
             margin={marginBetweenRatingIcon}
             onIconTap={onIconTap}
@@ -66,18 +66,18 @@ const Rating = ({
         <ColoredIcons percentage={percentage} dir={direction}>
           {Array.from({ length: totalCount }, (_, i) => (
             <IconBar
+              filled
               name={icon}
+              key={`cstar_${i}`}
               size={size}
-              color={ratingColor}
               position={i}
-              key={`cstar_${i}`}
+              color={ratingColor}
               margin={marginBetweenRatingIcon}
               onIconTap={onIconTap}
               readonly={readonly}
               type={type}
               selectedIconImage={selectedIconImage}
               emptyIconImage={emptyIconImage}
-              filled
             />
           ))}
         </ColoredIcons>