Unbounded memory leak.

[craftxbox]

930 and 931 both seem to have a very slow memory leak. Recently, I had left 931 open for ~4 days, to discover it had accumulated 17gb of system memory.

[CorruptComputer]

Sorry I thought I had replied to this before but I just saw that I had not.

This memory leak may be coming from Avalonia. There have been open issues for a memory leak when binding to Observables for quite some time and it does not seem to have been fixed.

AvaloniaUI/Avalonia#3527
AvaloniaUI/Avalonia#5872

With the refactoring done in #210 the usage of this has been removed from the Servers and Installation panels. Hopefully this means the leak isn't nearly as bad (or possibly even fixed). Still need to find if we are binding to Observables anywhere else and remove it if so.

I'm not 100% certain this will fix the entire issue, as I have been unable to reproduce this memory leak at all when testing so I'm not certain of the cause. I left the launcher open over night and didn't notice any significant memory usage increase so thats a good sign at least.