Bug fixing to this project

[mstrens]

There are several bugs reported here.
For several bugs, the fix has been provided but has not been put in the code of master branch.
Is it someone that keeps a version with all the fixes included?

[robomechs]

See #51
I've fixed some bugs and added A (B,C) axis.
Unfortunately @usbcnc has no activities since 2017.

[mstrens]

Thanks.
Still I presume that it does not contains the last bug fixes.
Would it not be better to open a new branch/repository on github to put all your changes/fixes?

[robomechs]

I'll see it a little bit later.
I think it will be reasonable. There are a lot of fixes now.

[robomechs]

Thanks.
Still I presume that it does not contains the last bug fixes.
Would it not be better to open a new branch/repository on github to put all your changes/fixes?

Done! #51
I will create a new repo, after I fix 5 and 6 axes.

[Alfrederson]

@yaroslavVl I found another bug. With the code the way it is, you cannot use M3 and M5 to toggle the state of the Spindle Enable pin because it's not initialized as an output.

If you add those two lines:

GPIO_InitStructure.GPIO_Pin = 1 << SPINDLE_ENABLE_BIT; GPIO_Init(SPINDLE_ENABLE_PORT, &GPIO_InitStructure); // <--- initializes the spindle enable pin

To the file spindle_control.c, after the line 68, which initializes the Spindle Dir pin with the function

GPIO_Init(SPINDLE_ENABLE_PORT, &GPIO_InitStructure);

Then M3 Sx will turn the spindle en bit high and M5 will turn it low. That's pretty much just the missing piece. With support for 4 and 5 axis this shapes up to be a really good CNC firmware and for a really inexpensive controller.

[robomechs]

I'll see it. 5 and 6 axis are not done yet. There are some bugs with it.