Skip to content

Commit 909e35a

Browse files
committed
Remove the ahead filter from the settings
1 parent 229d0ce commit 909e35a

File tree

3 files changed

+1
-40
lines changed

3 files changed

+1
-40
lines changed

website/index.html

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -139,23 +139,6 @@
139139
<section class="modal-card-body">
140140
<p>Settings will be saved on your local browser and will apply to your future queries.</p><br/>
141141

142-
<!-- Amount of commit diffs for the automatic filtering. -->
143-
<div class="field is-horizontal">
144-
<div class="field-label is-normal">
145-
<label class="label">Ahead filter:</label>
146-
</div>
147-
<div class="field-body">
148-
<div class="field">
149-
<div class="control">
150-
<input id="uf_settings_filter" class="input is-small is-fullwidth has-tooltip-arrow"
151-
type="number" value="0" min="1"
152-
placeholder="Default is 0" required>
153-
</div>
154-
<p class="help mb-2"><strong>Default is 0.</strong> If the amount of 'ahead' commits is less than or equal to this value, the fork is automatically removed from the list.</p>
155-
</div>
156-
</div>
157-
</div>
158-
159142
<!-- Relationship used for the commit diff count. -->
160143
<div class="field is-horizontal">
161144
<div class="field-label is-normal">

website/src/queries-logic.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ let TABLE_DATA = [];
66
let REPO_DATE;
77
let TOTAL_FORKS;
88
let RATE_LIMIT_EXCEEDED;
9-
let AHEAD_COMMITS_FILTER;
109
let TOTAL_API_CALLS_COUNTER;
1110
let ONGOING_REQUESTS_COUNTER = 0;
1211
let IS_USEFUL_FORK; // function that determines if a fork is useful or not
@@ -26,7 +25,6 @@ function clear_old_data() {
2625
RATE_LIMIT_EXCEEDED = false;
2726
TOTAL_API_CALLS_COUNTER = 0;
2827
ONGOING_REQUESTS_COUNTER = 0;
29-
AHEAD_COMMITS_FILTER = UF_SETTINGS_AHEAD_FILTER;
3028
shouldTriggerQueryOnTokenSave = false;
3129
}
3230

@@ -234,7 +232,7 @@ function update_table_data(responseData, user, repo, parentDefaultBranch) {
234232
head: `${extract_username_from_fork(currFork.full_name)}:${currFork.default_branch}`
235233
});
236234
const onSuccess = (responseHeaders, responseData) => {
237-
if (responseData.total_commits > AHEAD_COMMITS_FILTER) {
235+
if (responseData.total_commits > 0) {
238236
datum['ahead_by'] = responseData.ahead_by;
239237
datum['ahead_url'] = responseData.html_url;
240238
datum['behind_by'] = responseData.behind_by;

website/src/settings.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,21 @@
11
const JQ_SETTINGS_POPUP = $('#uf_settings_popup');
2-
const JQ_SETTINGS_FILTER = $('#uf_settings_filter');
32
const JQ_SETTINGS_CSV = $('#uf_settings_csv');
43

54

65
function openSettingsDialog() {
76
ga_openSettings();
8-
setAheadFilter();
97
setCsvDisplay();
108
JQ_SETTINGS_POPUP.addClass('is-active');
119
}
1210
function closeSettingsDialog() {
1311
JQ_SETTINGS_POPUP.removeClass('is-active');
1412
}
1513
function saveSettingsBtnClicked() {
16-
saveAheadFilter();
1714
saveCsvDisplay();
1815
closeSettingsDialog();
1916
}
2017

2118

22-
/* The "Ahead By Commit Filter" setting. */
23-
const LOCAL_STORAGE_SETTINGS_AHEAD_FILTER = "useful-forks-ahead-filter";
24-
let UF_SETTINGS_AHEAD_FILTER;
25-
function saveAheadFilter() {
26-
UF_SETTINGS_AHEAD_FILTER = JQ_SETTINGS_FILTER.val();
27-
localStorage.setItem(LOCAL_STORAGE_SETTINGS_AHEAD_FILTER, UF_SETTINGS_AHEAD_FILTER);
28-
}
29-
function setAheadFilter() {
30-
UF_SETTINGS_AHEAD_FILTER = localStorage.getItem(LOCAL_STORAGE_SETTINGS_AHEAD_FILTER);
31-
if (!UF_SETTINGS_AHEAD_FILTER) {
32-
UF_SETTINGS_AHEAD_FILTER = 0; // default
33-
}
34-
JQ_SETTINGS_FILTER.val(UF_SETTINGS_AHEAD_FILTER);
35-
}
36-
setAheadFilter();
37-
38-
3919
/* The "Export CSV Display" setting. */
4020
const LOCAL_STORAGE_SETTINGS_CSV_DISPLAY = "useful-forks-csv-display";
4121
let UF_SETTINGS_CSV_DISPLAY; // a boolean

0 commit comments

Comments
 (0)