Don’t attempt to serialize resources when the context is unsupported

Author: benedikt

lib/userlist/push/serializer.rb

@@ -19,7 +19,10 @@ def serialize(resource)
       end
 
       def serialize?(resource)
-        resource.public_send("#{context}?")
+        method_name = "#{context}?"
+
+        resource.respond_to?(method_name) &&
+          resource.public_send(method_name)
       end
 
     private

spec/userlist/push/serializer_spec.rb

@@ -76,12 +76,36 @@
       end
 
       context 'when serializing the user is not allowed' do
-        before do
-          allow_any_instance_of(Userlist::Push::User).to receive(:push?).and_return(false)
+        context 'when the context is push' do
+          subject { described_class.new(context: :push) }
+
+          before do
+            expect_any_instance_of(Userlist::Push::User).to receive(:push?).and_return(false)
+          end
+
+          it 'should return no payload' do
+            expect(payload).to_not be
+          end
         end
 
-        it 'should return no payload' do
-          expect(payload).to_not be
+        context 'when the context is delete' do
+          subject { described_class.new(context: :delete) }
+
+          before do
+            expect_any_instance_of(Userlist::Push::User).to receive(:delete?).and_return(false)
+          end
+
+          it 'should return no payload' do
+            expect(payload).to_not be
+          end
+        end
+
+        context 'when the context is unsupported' do
+          subject { described_class.new(context: :unsupported) }
+
+          it 'should return no payload' do
+            expect(payload).to_not be
+          end
         end
       end