Make it possible to swap between glibc and bionic without reinstall

[utkarshdalal]

Currently, both imagefs_gamenative (glibc) and imagefs_bionic extract to the /data/data/app.gamenative/files/imagefs folder. This means that both cannot be installed in parallel, and we need to install one or the other when running games.

I believe this is possibly fixed by instead extracting to /data/data/app.gamenative/files/glibc/imagefs and /data/data/app.gamenative/files/bionic/imagefs, and then creating a symlink on the fly when running a game to /data/data/app.gamenative/files/imagefs

[darkcl]

Hi... I have been trying to do this because this solves my issue on the load time switching between games (also tried to learn something new 😆 )

would like to have a discussion here because I encountered some issues:

I tried the symlinking method, and it does not launch any game (both glibc and bionic), and I found out that /home and /opt both have some essential files to let the game run.

Then I move the /home and /opt and symlink them inside both glibc and bionic folder, the bionic game can launch, but glibc won't boot (the steamclient not found, even though my symlink point to the correct folder)

Now in my local branch, I will extract glibc / bionic if needed and copy everything into the imagefs folder, and both variants work.

It saved some time, but it still has a long load time whenever I swap between glibc and bionic game, and I found out that whenever I swap between glibc and bionic, the app will remove the proton / wine installation and extract it again in /opt.

My question:
Can we skip this process? Any side-effect if we don't clear them? (I tried keeping those files, and both glibc and bionic can boot normally)

Ref:

    private static void clearOptDir(Context context, File optDir) {
        File[] files = optDir.listFiles();
        if (files == null) return;

        for (File file : files) {
            String fileName = file.getName();

            if (fileName.equals("installed-wine")) continue;

            // Keep imported Wine/Proton installations
            if (isImportedWineProton(context, fileName)) {
                Log.d("ImageFsInstaller", "Preserving imported installation: " + fileName);
                continue;
            }

            // Delete everything else
            FileUtils.delete(file);
        }
    }

    private static boolean isImportedWineProton(Context context, String fileName) {
        String lowerName = fileName.toLowerCase();

        // Not a Wine/Proton directory
        if (!lowerName.startsWith("wine-") && !lowerName.startsWith("proton-")) {
            return false;
        }

        // Get bundled versions from resource arrays
        String[] bionicWineEntries = context.getResources().getStringArray(R.array.bionic_wine_entries);
        String[] glibcWineEntries = context.getResources().getStringArray(R.array.glibc_wine_entries);

        // Check if it's a bundled version
        for (String version : bionicWineEntries) {
            if (lowerName.equals(version.toLowerCase())) return false;
        }
        for (String version : glibcWineEntries) {
            if (lowerName.equals(version.toLowerCase())) return false;
        }

        // It's Wine/Proton but not bundled, so it's imported
        return true;
    }

[utkarshdalal]

Awesome, nice job. The deletion happens only because we were reinstalling every time. You should be able to skip clearOptDir with no negative side effects.

[darkcl]

👌 i will create a PR when it is ready (the UI is a little bit weird when it is copying files)