Skip to content

Commit 2c81d23

Browse files
Make sure all promises errors are caught in scheduled function and schedule it every 5 mins
1 parent 1478035 commit 2c81d23

File tree

2 files changed

+31
-7
lines changed

2 files changed

+31
-7
lines changed

functions/src/functions/onSchedule.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { getServiceFactory } from "../services/factory/getServiceFactory.js";
1313

1414
export const onScheduleEveryMorning = onSchedule(
1515
{
16-
schedule: "0 8 * * *",
16+
schedule: "*/5 * * * *",
1717
timeZone: "America/Los_Angeles",
1818
serviceAccount: privilegedServiceAccount,
1919
secrets: Env.twilioSecretKeys,

functions/src/services/trigger/triggerService.ts

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,41 @@ export class TriggerService {
6363
patients,
6464
messageService,
6565
now,
66-
}),
66+
}).catch((error) =>
67+
logger.error(
68+
`everyMorning: Error adding daily reminders: ${String(error)}`,
69+
),
70+
),
6771
this.addInactivityReminderMessages({
6872
patients,
6973
now,
7074
messageService,
7175
userService,
72-
}),
73-
this.addAppointmentReminderMessages(now),
74-
this.completeAppointmentReminderMessages(now),
75-
this.seedStaticDataIfNeeded(),
76-
this.deleteExpiredAccounts(),
76+
}).catch((error) =>
77+
logger.error(
78+
`everyMorning: Error adding inactivity reminders: ${String(error)}`,
79+
),
80+
),
81+
this.addAppointmentReminderMessages(now).catch((error) =>
82+
logger.error(
83+
`everyMorning: Error adding appointment reminders: ${String(error)}`,
84+
),
85+
),
86+
this.completeAppointmentReminderMessages(now).catch((error) =>
87+
logger.error(
88+
`everyMorning: Error completing appointment reminders: ${String(error)}`,
89+
),
90+
),
91+
this.seedStaticDataIfNeeded().catch((error) =>
92+
logger.error(
93+
`everyMorning: Error seeding static data: ${String(error)}`,
94+
),
95+
),
96+
this.deleteExpiredAccounts().catch((error) =>
97+
logger.error(
98+
`everyMorning: Error deleting expired accounts: ${String(error)}`,
99+
),
100+
),
77101
]);
78102
}
79103

0 commit comments

Comments
 (0)