Skip to content

Commit 5360828

Browse files
author
Georgii Rychko
authored
fix(*): import rxjs in a proper way. Closes #172 (#173)
1 parent d776886 commit 5360828

14 files changed

+37
-8
lines changed

e2e/app.e2e-spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ describe('Tree App', () => {
3737
return antiquaNode.getAttribute(key).then((value: string) => expect(value).toEqual(attrs[key]));
3838
});
3939

40-
return Promise.all(expectations);
40+
return Promise.all(expectations as any);
4141
});
4242
});

e2e/tslint.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"extends": ["../tslint.json"],
3+
"rules": {
4+
"rxjs-add": { "severity": "off" }
5+
}
6+
}

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
"protractor": "5.2.0",
8686
"rimraf": "2.6.2",
8787
"rxjs": "5.5.2",
88+
"rxjs-tslint-rules": "3.1.2",
8889
"shelljs": "0.7.8",
8990
"systemjs-builder": "0.16.12",
9091
"ts-node": "3.3.0",

src/draggable/node-draggable.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Injectable, ElementRef } from '@angular/core';
2-
import { Subject } from 'rxjs/Rx';
2+
import { Subject } from 'rxjs/Subject';
33
import { CapturedNode } from './captured-node';
44
import { NodeDraggableEvent } from './draggable.events';
55

src/menu/node-menu.service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Injectable, ElementRef } from '@angular/core';
2-
import { Subject, Observable } from 'rxjs/Rx';
2+
import { Subject } from 'rxjs/Subject';
3+
import { Observable } from 'rxjs/Observable';
34
import { NodeMenuEvent, NodeMenuAction } from './menu.events';
45

56
@Injectable()

src/rxjs-imports.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import 'rxjs/add/operator/filter';
2+
import 'rxjs/add/observable/of';
3+

src/tree.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import './rxjs-imports';
2+
13
import { NgModule } from '@angular/core';
24
import { TreeComponent } from './tree.component';
35
import { TreeInternalComponent } from './tree-internal.component';

src/tree.service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import {
1212
import { RenamableNode } from './tree.types';
1313
import { Tree } from './tree';
1414
import { TreeController } from './tree-controller';
15-
import { Observable, Subject } from 'rxjs/Rx';
15+
import { Observable } from 'rxjs/Observable';
16+
import { Subject } from 'rxjs/Subject';
1617
import { ElementRef, Inject, Injectable } from '@angular/core';
1718
import { NodeDraggableService } from './draggable/node-draggable.service';
1819
import { NodeDraggableEvent } from './draggable/draggable.events';

src/tree.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import {
1212
defaultsDeep
1313
} from './utils/fn.utils';
1414

15-
import { Observable, Observer } from 'rxjs/Rx';
15+
import { Observable } from 'rxjs/Observable';
16+
import { Observer } from 'rxjs/Observer';
1617
import { TreeModel, RenamableNode, FoldingType, TreeStatus, TreeModelSettings, ChildrenLoadingFunction } from './tree.types';
1718
import { NodeMenuItem } from './menu/node-menu.component';
1819

test/draggable/node-draggable.service.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { inject, TestBed } from '@angular/core/testing';
2-
import { Subject } from 'rxjs/Rx';
2+
import { Subject } from 'rxjs/Subject';
33
import { NodeDraggableService } from '../../src/draggable/node-draggable.service';
44
import { CapturedNode } from '../../src/draggable/captured-node';
55
import { ElementRef } from '@angular/core';

0 commit comments

Comments
 (0)