Skip to content

Commit 608b683

Browse files
fix gha env vars again
1 parent 057a3a5 commit 608b683

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

.github/workflows/nodejs.yml

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ defaults:
1010
shell: bash
1111
env:
1212
NODE_VERSION: 18.x
13-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1413
jobs:
1514
build:
1615
runs-on: ${{matrix.os}}
@@ -21,22 +20,7 @@ jobs:
2120
- ubuntu-20.04
2221
- windows-latest
2322
fail-fast: false
24-
env:
25-
CSC_LINK: ${{ secrets.MAC_CERT_P12_BASE64 }}
26-
CSC_KEY_PASSWORD: ${{ secrets.MAC_CERT_P12_PASSWORD }}
27-
WIN_CSC_LINK: ${{ secrets.WIN_CERT_P12_BASE64 }}
28-
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CERT_P12_PASSWORD }}
29-
APPLE_ID: ${{ secrets.APPLE_ID }}
30-
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
3123
steps:
32-
- name: Cleanup Environment variables
33-
run: |
34-
if [ -z "$CSC_LINK" ] ; then unset CSC_LINK ; fi
35-
if [ -z "$CSC_KEY_PASSWORD" ] ; then unset CSC_KEY_PASSWORD ; fi
36-
if [ -z "$WIN_CSC_LINK" ] ; then unset WIN_CSC_LINK ; fi
37-
if [ -z "$WIN_CSC_KEY_PASSWORD" ] ; then unset WIN_CSC_KEY_PASSWORD ; fi
38-
if [ -z "$APPLE_ID" ] ; then unset APPLE_ID ; fi
39-
if [ -z "$APPLE_APP_SPECIFIC_PASSWORD" ] ; then unset APPLE_APP_SPECIFIC_PASSWORD ; fi
4024
- name: Checkout
4125
uses: actions/checkout@v3
4226
- name: Use Node.js ${{ env.NODE_VERSION }}
@@ -62,7 +46,22 @@ jobs:
6246
cp build/canary.ico build/icon.ico
6347
cp build/canary.icns build/icon.icns
6448
- name: Build
65-
run: yarn run dist
49+
run: |
50+
if [ -z "$CSC_LINK" ] ; then unset CSC_LINK ; fi
51+
if [ -z "$CSC_KEY_PASSWORD" ] ; then unset CSC_KEY_PASSWORD ; fi
52+
if [ -z "$WIN_CSC_LINK" ] ; then unset WIN_CSC_LINK ; fi
53+
if [ -z "$WIN_CSC_KEY_PASSWORD" ] ; then unset WIN_CSC_KEY_PASSWORD ; fi
54+
if [ -z "$APPLE_ID" ] ; then unset APPLE_ID ; fi
55+
if [ -z "$APPLE_APP_SPECIFIC_PASSWORD" ] ; then unset APPLE_APP_SPECIFIC_PASSWORD ; fi
56+
yarn run dist
57+
env:
58+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
59+
CSC_LINK: ${{ secrets.MAC_CERT_P12_BASE64 }}
60+
CSC_KEY_PASSWORD: ${{ secrets.MAC_CERT_P12_PASSWORD }}
61+
WIN_CSC_LINK: ${{ secrets.WIN_CERT_P12_BASE64 }}
62+
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CERT_P12_PASSWORD }}
63+
APPLE_ID: ${{ secrets.APPLE_ID }}
64+
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
6665
- name: Archive Build Artifacts
6766
uses: LabhanshAgrawal/upload-artifact@v3
6867
with:
@@ -157,6 +156,8 @@ jobs:
157156
npm_config_arch=armv7l yarn run v8-snapshot:arch
158157
- name: Build
159158
run: yarn run electron-builder -l deb rpm AppImage --${{ matrix.name }} -c electron-builder-linux-ci.json
159+
env:
160+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
160161
- name: Archive Build Artifacts
161162
uses: LabhanshAgrawal/upload-artifact@v3
162163
with:

0 commit comments

Comments
 (0)