Additional error debugging when failing to validate server response (#647)

Author: TooTallNate

.changeset/whole-lights-camp.md

@@ -0,0 +1,5 @@
+---
+"@workflow/world-vercel": patch
+---
+
+Additional error debugging when failing to validate server response

packages/world-vercel/src/utils.ts

@@ -2,7 +2,7 @@ import os from 'node:os';
 import { getVercelOidcToken } from '@vercel/oidc';
 import { WorkflowAPIError } from '@workflow/errors';
 import { type StructuredError, StructuredErrorSchema } from '@workflow/world';
-import { ZodError, type z } from 'zod';
+import type { z } from 'zod';
 import { version } from './version.js';
 
 export interface APIConfig {
@@ -174,10 +174,11 @@ export async function makeRequest<T>({
   headers.set('X-Request-Time', Date.now().toString());
 
   const url = `${baseUrl}${endpoint}`;
-  const response = await fetch(url, {
+  const request = new Request(url, {
     ...options,
     headers,
-  } as RequestInit);
+  });
+  const response = await fetch(request);
 
   if (!response.ok) {
     const errorData = (await response.json().catch(() => ({}))) as any;
@@ -186,28 +187,23 @@ export async function makeRequest<T>({
         .map(([key, value]: [string, string]) => `-H "${key}: ${value}"`)
         .join(' ');
       console.error(
-        `Failed to fetch, reproduce with:\ncurl -X ${options.method} ${stringifiedHeaders} "${url}"`
+        `Failed to fetch, reproduce with:\ncurl -X ${request.method} ${stringifiedHeaders} "${url}"`
       );
     }
     throw new WorkflowAPIError(
       errorData.message ||
-        `${options.method ?? 'GET'} ${endpoint} -> HTTP ${response.status}: ${response.statusText}`,
+        `${request.method} ${endpoint} -> HTTP ${response.status}: ${response.statusText}`,
       { url, status: response.status, code: errorData.code }
     );
   }
 
+  const text = await response.text();
+
   try {
-    const text = await response.text();
     return schema.parse(JSON.parse(text));
   } catch (error) {
-    if (error instanceof ZodError) {
-      throw new WorkflowAPIError(
-        `Failed to parse server response for ${options.method ?? 'GET'} ${endpoint}: ${error.message}`,
-        { url, cause: error }
-      );
-    }
     throw new WorkflowAPIError(
-      `Failed to parse server response for ${options.method ?? 'GET'} ${endpoint}`,
+      `Failed to parse server response for ${request.method} ${endpoint}:\n\n${error}\n\nResponse body: ${text}`,
       { url, cause: error }
     );
   }