Skip to content

Commit c770e94

Browse files
committed
Minor refactoring
1 parent e3c029b commit c770e94

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

src/main/java/in/erail/model/ResponseEvent.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,13 +167,8 @@ public ResponseEvent setContentType(MediaType pMediaType) {
167167
return this;
168168
}
169169

170-
public ResponseEvent addHeader(String pHeaderName, String pMediaType) {
171-
mMultiValueHeaders.add(HttpHeaders.CONTENT_TYPE, pMediaType);
172-
return this;
173-
}
174-
175-
public ResponseEvent addHeader(String pHeaderName, MediaType pMediaType) {
176-
addHeader(HttpHeaders.CONTENT_TYPE, pMediaType.toString());
170+
public ResponseEvent addHeader(String pHeaderName, String pValue) {
171+
mMultiValueHeaders.add(pHeaderName, pValue);
177172
return this;
178173
}
179174

src/main/java/in/erail/route/OpenAPI3RouteBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ public HttpServerResponse buildResponseFromReply(JsonObject pReplyResponse, Rout
154154

155155
Optional<String> contentType = Optional.ofNullable(response.headerValue(HttpHeaders.CONTENT_TYPE));
156156

157-
if (contentType.isPresent()) {
158-
response.addHeader(HttpHeaders.CONTENT_TYPE, MediaType.OCTET_STREAM);
157+
if (!contentType.isPresent()) {
158+
response.setContentType(MediaType.OCTET_STREAM);
159159
}
160160

161161
response

src/test/java/in/erail/service/BinaryBodyService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package in.erail.service;
22

33
import com.google.common.base.Strings;
4-
import com.google.common.net.HttpHeaders;
54
import com.google.common.net.MediaType;
65

76
import in.erail.model.RequestEvent;
@@ -28,7 +27,7 @@ public Maybe<ResponseEvent> process(RequestEvent pRequest) {
2827
}
2928

3029
ResponseEvent response = new ResponseEvent();
31-
response.addHeader(HttpHeaders.CONTENT_TYPE, MediaType.PLAIN_TEXT_UTF_8);
30+
response.setContentType(MediaType.PLAIN_TEXT_UTF_8);
3231

3332
JsonObject jsonBody = new JsonObject(Buffer.buffer(pRequest.getBody()));
3433

src/test/java/in/erail/service/BroadcastService.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package in.erail.service;
22

33
import com.google.common.base.Strings;
4-
import com.google.common.net.HttpHeaders;
54
import com.google.common.net.MediaType;
6-
import in.erail.test.TestConstants;
7-
import io.vertx.core.json.JsonObject;
5+
86
import in.erail.model.RequestEvent;
97
import in.erail.model.ResponseEvent;
8+
import in.erail.test.TestConstants;
109
import io.netty.handler.codec.http.HttpResponseStatus;
1110
import io.reactivex.Maybe;
11+
import io.vertx.core.json.JsonObject;
1212

1313
/**
1414
*
@@ -35,7 +35,7 @@ public Maybe<ResponseEvent> process(RequestEvent pRequest) {
3535

3636
ResponseEvent response = new ResponseEvent();
3737
response.setBody(TestConstants.Service.Message.successMessage().toString().getBytes());
38-
response.addHeader(HttpHeaders.CONTENT_TYPE, MediaType.JSON_UTF_8);
38+
response.setContentType(MediaType.JSON_UTF_8);
3939

4040
return Maybe.just(response);
4141
}

0 commit comments

Comments
 (0)