Skip to content

Commit cbc6c28

Browse files
committed
Refactored code
1 parent ed6e176 commit cbc6c28

File tree

6 files changed

+26
-9
lines changed

6 files changed

+26
-9
lines changed

src/main/java/in/erail/model/ResponseEvent.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,13 @@ public ResponseEvent setContentType(String pContentType) {
162162
return this;
163163
}
164164

165-
public ResponseEvent setContentType(MediaType pMediaType) {
166-
setContentType(pMediaType.toString());
165+
/**
166+
* Predefined Content Type
167+
* @param pMediaType
168+
* @return Response Event
169+
*/
170+
public ResponseEvent setMediaType(MediaType pMediaType) {
171+
ResponseEvent.this.setContentType(pMediaType.toString());
167172
return this;
168173
}
169174

src/main/java/in/erail/route/LoadUserFromAccessTokenRouteBuillder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
public class LoadUserFromAccessTokenRouteBuillder extends AbstractRouterBuilderImpl {
1717

18-
private Pattern AUTH_TOKEN = Pattern.compile("^Bearer\\s(?<token>.*)");
18+
private final Pattern AUTH_TOKEN = Pattern.compile("^Bearer\\s(?<token>.*)");
1919
private UserProvider mUserProvider;
2020

2121
@Override

src/main/java/in/erail/route/OpenAPI3RouteBuilder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public HttpServerResponse buildResponseFromReply(JsonObject pReplyResponse, Rout
155155
Optional<String> contentType = Optional.ofNullable(response.headerValue(HttpHeaders.CONTENT_TYPE));
156156

157157
if (!contentType.isPresent()) {
158-
response.setContentType(MediaType.OCTET_STREAM);
158+
response.setMediaType(MediaType.OCTET_STREAM);
159159
}
160160

161161
response
@@ -231,6 +231,7 @@ public Router getRouter(Router pRouter) {
231231
.asList(t)
232232
.stream()
233233
.forEach((service) -> {
234+
getLog().debug(() -> "Adding OpenAPI service handle:" + service.getOperationId());
234235
apiFactory.addHandlerByOperationId(service.getOperationId(), (routingContext) -> {
235236
if (isSecurityEnable()) {
236237

src/main/java/in/erail/service/RESTServiceImpl.java

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,15 @@
2020
*/
2121
public abstract class RESTServiceImpl implements RESTService {
2222

23+
private static final ResponseEvent DEFAULT_REPONSE_EVENT = new ResponseEvent();
24+
2325
private String mOperationId;
2426
private String mServiceUniqueId;
2527
private Vertx mVertx;
2628
private boolean mEnable = false;
2729
private Logger mLog;
2830
private Scheduler mScheduler = Schedulers.io();
31+
private ResponseEvent mDefaultResponseEvent = DEFAULT_REPONSE_EVENT;
2932

3033
@StartService
3134
public void start() {
@@ -39,7 +42,7 @@ public void start() {
3942
.doOnTerminate(() -> getLog().info(() -> String.format("%s[%s] service stopped", getServiceUniqueId(), Thread.currentThread().getName())))
4043
.flatMapSingle(this::handleRequest)
4144
.subscribe(
42-
resp -> getLog().trace(() -> resp.toString()),
45+
resp -> getLog().trace(() -> resp.toString()),
4346
err -> getLog().error(() -> String.format("Process exception:[%s],Error:[%s]", getServiceUniqueId(), ExceptionUtils.getStackTrace(err)))
4447
);
4548
}
@@ -50,13 +53,13 @@ public Single<JsonObject> handleRequest(Message<JsonObject> pMessage) {
5053
.just(pMessage)
5154
.map(m -> pMessage.body().mapTo(RequestEvent.class))
5255
.flatMapMaybe(req -> process(req))
53-
.toSingle(new ResponseEvent())
56+
.toSingle(getDefaultResponseEvent())
5457
.map(resp -> JsonObject.mapFrom(resp))
5558
.doOnSuccess(resp -> pMessage.reply(resp))
5659
.doOnError(err -> {
5760
ResponseEvent resp = new ResponseEvent()
5861
.setStatusCode(HttpResponseStatus.BAD_REQUEST.code())
59-
.setContentType(MediaType.PLAIN_TEXT_UTF_8)
62+
.setMediaType(MediaType.PLAIN_TEXT_UTF_8)
6063
.setBody(ExceptionUtils.getMessage(err).getBytes());
6164
pMessage.reply(JsonObject.mapFrom(resp));
6265
});
@@ -112,4 +115,12 @@ public void setScheduler(Scheduler pScheduler) {
112115
this.mScheduler = pScheduler;
113116
}
114117

118+
public ResponseEvent getDefaultResponseEvent() {
119+
return mDefaultResponseEvent;
120+
}
121+
122+
public void setDefaultResponseEvent(ResponseEvent pDefaultResponseEvent) {
123+
this.mDefaultResponseEvent = pDefaultResponseEvent;
124+
}
125+
115126
}

src/test/java/in/erail/service/BinaryBodyService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public Maybe<ResponseEvent> process(RequestEvent pRequest) {
2727
}
2828

2929
ResponseEvent response = new ResponseEvent();
30-
response.setContentType(MediaType.PLAIN_TEXT_UTF_8);
30+
response.setMediaType(MediaType.PLAIN_TEXT_UTF_8);
3131

3232
JsonObject jsonBody = new JsonObject(Buffer.buffer(pRequest.getBody()));
3333

src/test/java/in/erail/service/BroadcastService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public Maybe<ResponseEvent> process(RequestEvent pRequest) {
3535

3636
ResponseEvent response = new ResponseEvent();
3737
response.setBody(TestConstants.Service.Message.successMessage().toString().getBytes());
38-
response.setContentType(MediaType.JSON_UTF_8);
38+
response.setMediaType(MediaType.JSON_UTF_8);
3939

4040
return Maybe.just(response);
4141
}

0 commit comments

Comments
 (0)