Fixed sonar bugs

Author: pokki-deploy

src/main/java/in/erail/scheduler/QuartzJobFactory.java

@@ -28,7 +28,7 @@
 public class QuartzJobFactory implements JobFactory {
 
   public static final String COMPONENT_PATH = "_comp";
-  
+
   private boolean warnIfNotFound = false;
   private boolean throwIfNotFound = false;
   private Logger mLog = LogManager.getLogger(QuartzJobFactory.class);
@@ -39,12 +39,12 @@ public Job newJob(TriggerFiredBundle bundle, Scheduler scheduler) throws Schedul
     Optional<String> compPath = Optional
             .ofNullable(data.getString(COMPONENT_PATH))
             .filter(t -> !Strings.isNullOrEmpty(t));
-    
+
     Job job;
-    
-    if(compPath.isPresent()){
+
+    if (compPath.isPresent()) {
       job = Glue.instance().resolve(compPath.get());
-    }else {
+    } else {
       job = (Job) Util.createInstance(bundle.getJobDetail().getJobClass());
       getLog().warn(() -> "Create job instance from class, Instead of Component. Are you sure, you don't want to use Component:" + bundle.getJobDetail().getJobClass().getCanonicalName());
     }
@@ -95,6 +95,10 @@ protected void setBeanProps(Object obj, JobDataMap data) throws SchedulerExcepti
         paramType = setMeth.getParameterTypes()[0];
         o = entry.getValue();
 
+        if (o == null) {
+          continue;
+        }
+
         Object parm = null;
         if (paramType.isPrimitive()) {
           if (o == null) {

src/main/java/in/erail/security/SecurityTools.java

@@ -79,8 +79,10 @@ protected Single<byte[]> generateKey() {
   public String getGlobalUniqueString() {
     try {
       return mGlobalUniqueString.get();
-    } catch (InterruptedException | ExecutionException ex) {
+    } catch (ExecutionException ex) {
       getLog().error("Global Unique not working", ex);
+    } catch (InterruptedException ex) {
+      throw new RuntimeException(ex);
     }
     return "ERROR_GLOBAL_KEY";
   }
@@ -110,9 +112,10 @@ public String encrypt(String value) {
             | NoSuchPaddingException
             | IllegalBlockSizeException
             | BadPaddingException
-            | InterruptedException
             | ExecutionException ex) {
       getLog().error(ex);
+    } catch (InterruptedException ex) {
+      throw new RuntimeException(ex);
     }
 
     return null;
@@ -137,9 +140,10 @@ public String decrypt(String encrypted) {
             | InvalidAlgorithmParameterException
             | IllegalBlockSizeException
             | BadPaddingException
-            | InterruptedException
             | ExecutionException ex) {
       getLog().error(ex);
+    } catch (InterruptedException ex) {
+      throw new RuntimeException(ex);
     }
 
     return null;