Skip to content

Conversation

@kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Dec 5, 2025

Purpose

  • Delete unused code
  • Speed up load time by reducing the number of imported dependencies

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code maintainability and reducing technical debt by systematically removing dead code and centralizing common utility functions. By eliminating unused helper functions and consolidating shared utilities into the compressed_tensors.utils module, the codebase becomes leaner, easier to understand, and less prone to inconsistencies. This effort streamlines dependencies and improves the overall health of the project.

Highlights

  • Code Cleanup: A significant number of deprecated and unused utility functions, along with their associated constants and imports, have been removed from src/llmcompressor/utils/helpers.py.
  • Utility Centralization: The getattr_chain and patch_attr utility functions have been migrated from llmcompressor.utils.helpers to compressed_tensors.utils, and all internal references have been updated to import them from the new centralized location.
  • Test Refactoring: Corresponding unit tests for the removed utility functions in src/llmcompressor/utils/helpers.py have been deleted from tests/llmcompressor/utils/test_helpers.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kylesayrs kylesayrs marked this pull request as draft December 5, 2025 06:44
@kylesayrs kylesayrs changed the base branch from main to kylesayrs/deprecate December 5, 2025 06:44
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes deprecated utility functions and their associated imports and tests from llmcompressor.utils.helpers.py. Functions like getattr_chain and patch_attr have been consolidated into compressed_tensors.utils, leading to a cleaner and more maintainable codebase for llmcompressor. The changes are well-executed and align with the stated purpose of removing dead code. No issues of medium, high, or critical severity were found during the review.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants