Skip to content

Commit 681df0e

Browse files
py4Pooya Moradi
andauthored
[Buildkite] Move DP e2e test to DP.yml and run as nightly (#1221)
Signed-off-by: Pooya Moradi <pooyam@google.com> Co-authored-by: Pooya Moradi <pooyam@google.com>
1 parent c70abca commit 681df0e

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

.buildkite/parallelism/DP.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,14 @@ steps:
44
- label: "Correctness tests for DP"
55
key: "DP_CorrectnessTest"
66
soft_fail: true
7+
env:
8+
NEW_MODEL_DESIGN: "1"
79
agents:
8-
queue: tpu_v6e_queue
10+
queue: tpu_v6e_8_queue
911
commands:
1012
- |
11-
buildkite-agent meta-data set "DP_CorrectnessTest" "to be added"
13+
.buildkite/scripts/run_in_docker.sh \
14+
bash -c 'python3 -m pytest -s -v -x /workspace/tpu_inference/tests/e2e/test_data_parallel.py'
1215
- label: "Record correctness test result for DP"
1316
key: "record_DP_CorrectnessTest"
1417
depends_on: "DP_CorrectnessTest"

.buildkite/pipeline_jax.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -225,17 +225,6 @@ steps:
225225
echo "Skipping: NIGHTLY environment variable not set"
226226
exit 0
227227
fi
228-
- label: "E2E data parallelism test"
229-
key: test_14
230-
soft_fail: true
231-
env:
232-
NEW_MODEL_DESIGN: "1"
233-
agents:
234-
queue: tpu_v6e_8_queue
235-
commands:
236-
- |
237-
.buildkite/scripts/run_in_docker.sh \
238-
bash -c 'python3 -m pytest -s -v -x /workspace/tpu_inference/tests/e2e/test_data_parallel.py'
239228
240229
- label: "lora unit tests on single chip"
241230
key: test_15
@@ -280,7 +269,6 @@ steps:
280269
- test_11
281270
- test_12
282271
- test_13
283-
- test_14
284272
- test_15
285273
- test_16
286274
agents:
@@ -289,4 +277,3 @@ steps:
289277
- |
290278
.buildkite/scripts/check_results.sh \
291279
"TPU JAX Tests Failed" test_0 test_1 test_2 test_3 test_4 test_5 test_6 test_7 test_8 test_9 test_10 test_11 test_12 test_13 test_15 test_16
292-
# TODO (johnnyyang) : add DP test back to the list once feature is ready

0 commit comments

Comments
 (0)