Skip to content

Conversation

@wenxindongwork
Copy link
Collaborator

@wenxindongwork wenxindongwork commented Dec 4, 2025

Description

b/463427040

Tests

https://buildkite.com/tpu-commons/tpu-inference-ci/builds/6421/

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk kyuyeunk added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 4, 2025
@helloworld1
Copy link
Contributor

Already had a PR to fix #1235

@wenxindongwork wenxindongwork force-pushed the fix-kv-cache-casting branch 2 times, most recently from a1b8171 to ab6985e Compare December 6, 2025 07:38
Signed-off-by: wenxindongwork <wenxindong@google.com>
@kyuyeunk
Copy link
Collaborator

kyuyeunk commented Dec 6, 2025

Already had a PR to fix #1235

Thanks for providing the fix! I've left a comment in that pr. please update the branch so I can merge it when I confirm ci is all green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants