Skip to content

Commit f7acd2a

Browse files
committed
fix: add || true to all prepare commands in run.sh
The pnpm prepare command failed with a non-zero exit code, which caused hyperfine to abort the entire benchmark suite. Only npm, nx, turbo, and node had '|| true' appended to their prepare commands. This adds '|| true' to ALL prepare commands (yarn, berry, zpm, pnpm, vlt, bun, deno, vp) so that a transient install failure during the prepare step doesn't kill the entire task runner benchmark. hyperfine's --ignore-failure only applies to the measured command, not to --prepare commands, so || true is needed to prevent suite-wide failures from transient install issues.
1 parent a6d3fa6 commit f7acd2a

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

scripts/variations/run.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,21 +55,21 @@ hyperfine --ignore-failure \
5555
--cleanup="bash $BENCH_SCRIPTS/clean-helpers.sh clean_all" \
5656
${BENCH_INCLUDE_NPM:+--prepare="$BENCH_INSTALL_PREPARE_NPM || true"} \
5757
${BENCH_INCLUDE_NPM:+--command-name="npm" "$BENCH_COMMAND_NPM"} \
58-
${BENCH_INCLUDE_YARN:+--prepare="$BENCH_INSTALL_PREPARE_YARN"} \
58+
${BENCH_INCLUDE_YARN:+--prepare="$BENCH_INSTALL_PREPARE_YARN || true"} \
5959
${BENCH_INCLUDE_YARN:+--command-name="yarn" "$BENCH_COMMAND_YARN"} \
60-
${BENCH_INCLUDE_BERRY:+--prepare="$BENCH_INSTALL_PREPARE_BERRY"} \
60+
${BENCH_INCLUDE_BERRY:+--prepare="$BENCH_INSTALL_PREPARE_BERRY || true"} \
6161
${BENCH_INCLUDE_BERRY:+--command-name="berry" "$BENCH_COMMAND_BERRY"} \
62-
${BENCH_INCLUDE_ZPM:+--prepare="$BENCH_INSTALL_PREPARE_ZPM"} \
62+
${BENCH_INCLUDE_ZPM:+--prepare="$BENCH_INSTALL_PREPARE_ZPM || true"} \
6363
${BENCH_INCLUDE_ZPM:+--command-name="zpm" "$BENCH_COMMAND_ZPM"} \
64-
${BENCH_INCLUDE_PNPM:+--prepare="$BENCH_INSTALL_PREPARE_PNPM"} \
64+
${BENCH_INCLUDE_PNPM:+--prepare="$BENCH_INSTALL_PREPARE_PNPM || true"} \
6565
${BENCH_INCLUDE_PNPM:+--command-name="pnpm" "$BENCH_COMMAND_PNPM"} \
66-
${BENCH_INCLUDE_VLT:+--prepare="$BENCH_INSTALL_PREPARE_VLT"} \
66+
${BENCH_INCLUDE_VLT:+--prepare="$BENCH_INSTALL_PREPARE_VLT || true"} \
6767
${BENCH_INCLUDE_VLT:+--command-name="vlt" "$BENCH_COMMAND_VLT"} \
68-
${BENCH_INCLUDE_BUN:+--prepare="$BENCH_INSTALL_PREPARE_BUN"} \
68+
${BENCH_INCLUDE_BUN:+--prepare="$BENCH_INSTALL_PREPARE_BUN || true"} \
6969
${BENCH_INCLUDE_BUN:+--command-name="bun" "$BENCH_COMMAND_BUN"} \
70-
${BENCH_INCLUDE_DENO:+--prepare="$BENCH_INSTALL_PREPARE_DENO"} \
70+
${BENCH_INCLUDE_DENO:+--prepare="$BENCH_INSTALL_PREPARE_DENO || true"} \
7171
${BENCH_INCLUDE_DENO:+--command-name="deno" "$BENCH_COMMAND_DENO"} \
72-
${BENCH_INCLUDE_VP:+--prepare="$BENCH_INSTALL_PREPARE_VP"} \
72+
${BENCH_INCLUDE_VP:+--prepare="$BENCH_INSTALL_PREPARE_VP || true"} \
7373
${BENCH_INCLUDE_VP:+--command-name="vp" "$BENCH_COMMAND_VP"} \
7474
${BENCH_INCLUDE_NX:+--prepare="$BENCH_INSTALL_PREPARE_NPM || true"} \
7575
${BENCH_INCLUDE_NX:+--command-name="nx" "$BENCH_COMMAND_NX"} \

0 commit comments

Comments
 (0)