Merge branch 'vortex-data:develop' into push_validity_into_children_for_struct_array

Author: amorynan

.github/workflows/bench.yml

@@ -66,9 +66,8 @@ jobs:
         shell: bash
         env:
           RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes"
-        # The main difference between this and `bench-pr.yml` is that we add the `lance` feature.
         run: |
-          cargo build --bin ${{ matrix.benchmark.id }} --package vortex-bench --profile release_debug --features lance
+          cargo build --bin ${{ matrix.benchmark.id }} --package vortex-bench --profile release_debug
 
       - name: Setup Polar Signals
         uses: polarsignals/gh-actions-ps-profiling@v0.6.0

.github/workflows/ci.yml

@@ -595,7 +595,7 @@ jobs:
           RUSTFLAGS: "-C target-feature=+avx2 -C debug-assertions=yes"
         run: cargo codspeed build ${{ matrix.features }} $(printf -- '-p %s ' ${{ matrix.packages }}) --profile bench
       - name: Run benchmarks
-        uses: CodSpeedHQ/action@346a2d8a8d9d38909abd0bc3d23f773110f076ad
+        uses: CodSpeedHQ/action@972e3437949c89e1357ebd1a2dbc852fcbc57245
         with:
           run: cargo codspeed run
           token: ${{ secrets.CODSPEED_TOKEN }}

Cargo.lock

@@ -54,7 +54,7 @@
   - `vortex_panic!` for handling invariant violations
 - Add context to errors using `.with_context()`
 - Include backtraces for better debugging
-- Use `VortexExpect` and `VortexUnwrap` traits when unwrapping is appropriate
+- Use `VortexExpect` trait when unwrapping is appropriate with proper error context.
 
 ## Code Structure
 

STYLE.md

@@ -31,7 +31,6 @@ use vortex_dtype::DType;
 use vortex_dtype::NativePType;
 use vortex_dtype::match_each_integer_ptype;
 use vortex_error::VortexExpect;
-use vortex_error::VortexUnwrap;
 use vortex_error::vortex_panic;
 use vortex_utils::aliases::hash_map::HashMap;
 
@@ -229,15 +228,15 @@ impl RDEncoder {
         // SAFETY: by construction, all values in left_parts can be packed to left_bit_width.
         let packed_left = unsafe {
             bitpack_encode_unchecked(primitive_left, left_bit_width as _)
-                .vortex_unwrap()
+                .vortex_expect("bitpack_encode_unchecked should succeed for left parts")
                 .into_array()
         };
 
         let primitive_right = PrimitiveArray::new(right_parts, Validity::NonNullable);
         // SAFETY: by construction, all values in right_parts are right_bit_width + leading zeros.
         let packed_right = unsafe {
             bitpack_encode_unchecked(primitive_right, self.right_bit_width as _)
-                .vortex_unwrap()
+                .vortex_expect("bitpack_encode_unchecked should succeed for right parts")
                 .into_array()
         };
 
@@ -252,7 +251,9 @@ impl RDEncoder {
             // SAFETY: We calculate bw such that it is wide enough to hold the largest position index.
             let packed_pos = unsafe {
                 bitpack_encode_unchecked(exc_pos_array, bw)
-                    .vortex_unwrap()
+                    .vortex_expect(
+                        "bitpack_encode_unchecked should succeed for exception positions",
+                    )
                     .into_array()
             };
 

encodings/alp/src/alp_rd/mod.rs

@@ -26,6 +26,5 @@ vortex-mask = { workspace = true }
 vortex-scalar = { workspace = true }
 
 [dev-dependencies]
-itertools = { workspace = true }
 rstest = { workspace = true }
 vortex-array = { workspace = true, features = ["test-harness"] }

encodings/bytebool/Cargo.toml

@@ -27,6 +27,5 @@ vortex-mask = { workspace = true }
 vortex-scalar = { workspace = true }
 
 [dev-dependencies]
-itertools = { workspace = true }
 rstest = { workspace = true }
 vortex-array = { path = "../../vortex-array", features = ["test-harness"] }

encodings/decimal-byte-parts/Cargo.toml

@@ -37,7 +37,6 @@ vortex-vector = { workspace = true }
 [dev-dependencies]
 divan = { workspace = true }
 itertools = { workspace = true }
-mimalloc = { workspace = true }
 rand = { workspace = true }
 rstest = { workspace = true }
 vortex-alp = { path = "../alp" }

encodings/fastlanes/Cargo.toml

@@ -34,7 +34,6 @@ test-harness = ["dep:rand", "vortex-array/test-harness"]
 
 [dev-dependencies]
 divan = { workspace = true }
-itertools = { workspace = true }
 rand = { workspace = true }
 rstest = { workspace = true }
 vortex-array = { workspace = true, features = ["test-harness"] }

encodings/fsst/Cargo.toml

@@ -13,7 +13,6 @@ use vortex_buffer::Buffer;
 use vortex_buffer::BufferMut;
 use vortex_dtype::DType;
 use vortex_error::VortexExpect;
-use vortex_error::VortexUnwrap;
 
 use crate::FSSTArray;
 
@@ -74,7 +73,11 @@ where
                 uncompressed_lengths.push(0);
             }
             Some(s) => {
-                uncompressed_lengths.push(s.len().try_into().vortex_unwrap());
+                uncompressed_lengths.push(
+                    s.len()
+                        .try_into()
+                        .vortex_expect("string length must fit in i32"),
+                );
 
                 // SAFETY: buffer is large enough
                 unsafe { compressor.compress_into(s, &mut buffer) };