refactor(language-core): more robust code features resolution (#5177)

KazariEX · web-flow · commit 688a427e0c12 · 2025-02-14T16:24:30.000+08:00
diff --git a/packages/language-core/lib/codegen/codeFeatures.ts b/packages/language-core/lib/codegen/codeFeatures.ts
@@ -0,0 +1,72 @@
+import type { VueCodeInformation } from '../types';
+
+const raw = {
+	all: {
+		verification: true,
+		completion: true,
+		semantic: true,
+		navigation: true,
+	},
+	none: {},
+	verification: {
+		verification: true,
+	},
+	completion: {
+		completion: true,
+	},
+	additionalCompletion: {
+		completion: { isAdditional: true },
+	},
+	withoutCompletion: {
+		verification: true,
+		semantic: true,
+		navigation: true,
+	},
+	navigation: {
+		navigation: true,
+	},
+	navigationWithoutRename: {
+		navigation: { shouldRename: () => false },
+	},
+	navigationAndCompletion: {
+		navigation: true,
+		completion: true,
+	},
+	navigationAndAdditionalCompletion: {
+		navigation: true,
+		completion: { isAdditional: true },
+	},
+	navigationAndVerification: {
+		navigation: true,
+		verification: true,
+	},
+	withoutNavigation: {
+		verification: true,
+		completion: true,
+		semantic: true,
+	},
+	withoutHighlight: {
+		semantic: { shouldHighlight: () => false },
+		verification: true,
+		navigation: true,
+		completion: true,
+	},
+	withoutHighlightAndNavigation: {
+		semantic: { shouldHighlight: () => false },
+		verification: true,
+		completion: true,
+	},
+	withoutHighlightAndCompletion: {
+		semantic: { shouldHighlight: () => false },
+		verification: true,
+		navigation: true,
+	},
+	withoutHighlightAndCompletionAndNavigation: {
+		semantic: { shouldHighlight: () => false },
+		verification: true,
+	},
+} satisfies Record<string, VueCodeInformation>;
+
+export const codeFeatures = raw as {
+	[K in keyof typeof raw]: VueCodeInformation;
+};
diff --git a/packages/language-core/lib/codegen/script/component.ts b/packages/language-core/lib/codegen/script/component.ts
@@ -1,8 +1,9 @@
 import type { ScriptSetupRanges } from '../../parsers/scriptSetupRanges';
 import type { Code, Sfc } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import { endOfLine, generateSfcBlockSection, newLine } from '../utils';
 import type { ScriptCodegenContext } from './context';
-import { ScriptCodegenOptions, codeFeatures } from './index';
+import type { ScriptCodegenOptions } from './index';
 
 export function* generateComponent(
 	options: ScriptCodegenOptions,
diff --git a/packages/language-core/lib/codegen/script/componentSelf.ts b/packages/language-core/lib/codegen/script/componentSelf.ts
@@ -1,10 +1,11 @@
 import * as path from 'path-browserify';
 import type { Code } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import type { TemplateCodegenContext } from '../template/context';
 import { endOfLine, generateSfcBlockSection, newLine } from '../utils';
 import { generateComponentSetupReturns, generateEmitsOption, generatePropsOption } from './component';
 import type { ScriptCodegenContext } from './context';
-import { codeFeatures, type ScriptCodegenOptions } from './index';
+import type { ScriptCodegenOptions } from './index';
 import { getTemplateUsageVars } from './template';
 
 export function* generateComponentSelf(
diff --git a/packages/language-core/lib/codegen/script/index.ts b/packages/language-core/lib/codegen/script/index.ts
@@ -3,7 +3,8 @@ import * as path from 'path-browserify';
 import type * as ts from 'typescript';
 import type { ScriptRanges } from '../../parsers/scriptRanges';
 import type { ScriptSetupRanges } from '../../parsers/scriptSetupRanges';
-import type { Code, Sfc, VueCodeInformation, VueCompilerOptions } from '../../types';
+import type { Code, Sfc, VueCompilerOptions } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import { generateGlobalTypes, getGlobalTypesFileName } from '../globalTypes';
 import type { TemplateCodegenContext } from '../template/context';
 import { endOfLine, generateSfcBlockSection, newLine } from '../utils';
@@ -14,29 +15,6 @@ import { generateSrc } from './src';
 import { generateStyleModulesType } from './styleModulesType';
 import { generateTemplate } from './template';
 
-export const codeFeatures = {
-	all: {
-		verification: true,
-		completion: true,
-		semantic: true,
-		navigation: true,
-	} as VueCodeInformation,
-	none: {} as VueCodeInformation,
-	verification: {
-		verification: true,
-	} as VueCodeInformation,
-	navigation: {
-		navigation: true,
-	} as VueCodeInformation,
-	navigationWithoutRename: {
-		navigation: {
-			shouldRename() {
-				return false;
-			},
-		},
-	} as VueCodeInformation,
-};
-
 export interface ScriptCodegenOptions {
 	ts: typeof ts;
 	compilerOptions: ts.CompilerOptions;
diff --git a/packages/language-core/lib/codegen/script/scriptSetup.ts b/packages/language-core/lib/codegen/script/scriptSetup.ts
@@ -1,10 +1,11 @@
 import type { ScriptSetupRanges } from '../../parsers/scriptSetupRanges';
 import type { Code, Sfc, TextRange } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import { combineLastMapping, endOfLine, generateSfcBlockSection, newLine } from '../utils';
 import { generateComponent, generateEmitsOption } from './component';
 import { generateComponentSelf } from './componentSelf';
 import type { ScriptCodegenContext } from './context';
-import { ScriptCodegenOptions, codeFeatures, generateScriptSectionPartiallyEnding } from './index';
+import { ScriptCodegenOptions, generateScriptSectionPartiallyEnding } from './index';
 import { generateTemplate } from './template';
 
 export function* generateScriptSetupImports(
diff --git a/packages/language-core/lib/codegen/script/src.ts b/packages/language-core/lib/codegen/script/src.ts
@@ -1,6 +1,6 @@
 import type { Code, Sfc } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import { endOfLine } from '../utils';
-import { codeFeatures } from './index';
 
 export function* generateSrc(
 	script: NonNullable<Sfc['script']>,
diff --git a/packages/language-core/lib/codegen/script/styleModulesType.ts b/packages/language-core/lib/codegen/script/styleModulesType.ts
@@ -1,7 +1,8 @@
 import type { Code } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import { endOfLine, newLine } from '../utils';
 import type { ScriptCodegenContext } from './context';
-import { ScriptCodegenOptions, codeFeatures } from './index';
+import type { ScriptCodegenOptions } from './index';
 import { generateCssClassProperty } from './template';
 
 export function* generateStyleModulesType(
diff --git a/packages/language-core/lib/codegen/script/template.ts b/packages/language-core/lib/codegen/script/template.ts
@@ -1,11 +1,12 @@
 import type { Code } from '../../types';
 import { hyphenateTag } from '../../utils/shared';
+import { codeFeatures } from '../codeFeatures';
 import { TemplateCodegenContext, createTemplateCodegenContext } from '../template/context';
 import { generateInterpolation } from '../template/interpolation';
 import { generateStyleScopedClassReferences } from '../template/styleScopedClasses';
 import { endOfLine, newLine } from '../utils';
 import type { ScriptCodegenContext } from './context';
-import { codeFeatures, type ScriptCodegenOptions } from './index';
+import type { ScriptCodegenOptions } from './index';
 
 export function* generateTemplate(
 	options: ScriptCodegenOptions,
diff --git a/packages/language-core/lib/codegen/template/context.ts b/packages/language-core/lib/codegen/template/context.ts
@@ -1,74 +1,10 @@
 import type * as CompilerDOM from '@vue/compiler-dom';
 import type { Code, VueCodeInformation } from '../../types';
+import { codeFeatures } from '../codeFeatures';
 import { InlayHintInfo } from '../inlayHints';
 import { endOfLine, newLine, wrapWith } from '../utils';
 import type { TemplateCodegenOptions } from './index';
 
-const _codeFeatures = {
-	all: {
-		verification: true,
-		completion: true,
-		semantic: true,
-		navigation: true,
-	} as VueCodeInformation,
-	verification: {
-		verification: true,
-	} as VueCodeInformation,
-	completion: {
-		completion: true,
-	} as VueCodeInformation,
-	additionalCompletion: {
-		completion: { isAdditional: true },
-	} as VueCodeInformation,
-	navigation: {
-		navigation: true,
-	} as VueCodeInformation,
-	navigationWithoutRename: {
-		navigation: {
-			shouldRename() {
-				return false;
-			},
-		},
-	} as VueCodeInformation,
-	navigationAndCompletion: {
-		navigation: true,
-		completion: true,
-	} as VueCodeInformation,
-	navigationAndAdditionalCompletion: {
-		navigation: true,
-		completion: { isAdditional: true },
-	} as VueCodeInformation,
-	navigationAndVerification: {
-		navigation: true,
-		verification: true,
-	} as VueCodeInformation,
-	withoutNavigation: {
-		verification: true,
-		completion: true,
-		semantic: true,
-	} as VueCodeInformation,
-	withoutHighlight: {
-		semantic: { shouldHighlight: () => false },
-		verification: true,
-		navigation: true,
-		completion: true,
-	} as VueCodeInformation,
-	withoutHighlightAndNavigation: {
-		semantic: { shouldHighlight: () => false },
-		verification: true,
-		completion: true,
-	} as VueCodeInformation,
-	withoutHighlightAndCompletion: {
-		semantic: { shouldHighlight: () => false },
-		verification: true,
-		navigation: true,
-	} as VueCodeInformation,
-	withoutHighlightAndCompletionAndNavigation: {
-		semantic: { shouldHighlight: () => false },
-		verification: true,
-	} as VueCodeInformation,
-};
-
 export type TemplateCodegenContext = ReturnType<typeof createTemplateCodegenContext>;
 
 export function createTemplateCodegenContext(options: Pick<TemplateCodegenOptions, 'scriptSetupBindingNames' | 'edited'>) {
@@ -83,34 +19,30 @@ export function createTemplateCodegenContext(options: Pick<TemplateCodegenOption
 	} | undefined;
 	let variableId = 0;
 
-	const codeFeatures = new Proxy(_codeFeatures, {
-		get(target, key: keyof typeof _codeFeatures) {
-			const data = target[key];
-			if (data.verification) {
-				if (ignoredError) {
-					return {
-						...data,
-						verification: false,
-					};
-				}
-				if (expectErrorToken) {
-					const token = expectErrorToken;
-					if (typeof data.verification !== 'object' || !data.verification.shouldReport) {
-						return {
-							...data,
-							verification: {
-								shouldReport: () => {
-									token.errors++;
-									return false;
-								},
-							},
-						};
-					}
-				}
+	function resolveCodeFeatures(features: VueCodeInformation) {
+		if (features.verification) {
+			if (ignoredError) {
+				return {
+					...features,
+					verification: false,
+				};
 			}
-			return data;
-		},
-	});
+			if (expectErrorToken) {
+				const token = expectErrorToken;
+				return {
+					...features,
+					verification: {
+						shouldReport: () => {
+							token.errors++;
+							return false;
+						}
+ 					},
+				};
+			}
+		}
+		return features;
+	}
+
 	const localVars = new Map<string, number>();
 	const specialVars = new Set<string>();
 	const accessExternalVariables = new Map<string, Set<number>>();
@@ -138,9 +70,15 @@ export function createTemplateCodegenContext(options: Pick<TemplateCodegenOption
 	const templateRefs = new Map<string, [varName: string, offset: number]>();
 
 	return {
+		codeFeatures: new Proxy(codeFeatures, {
+			get(target, key: keyof typeof codeFeatures) {
+				const data = target[key];
+				return resolveCodeFeatures(data);
+			},
+		}),
+		resolveCodeFeatures,
 		slots,
 		dynamicSlots,
-		codeFeatures,
 		specialVars,
 		accessExternalVariables,
 		lastGenericComment,
diff --git a/packages/language-core/lib/codegen/template/element.ts b/packages/language-core/lib/codegen/template/element.ts
@@ -134,10 +134,7 @@ export function* generateComponent(
 				options,
 				ctx,
 				'template',
-				{
-					...ctx.codeFeatures.all,
-					completion: false,
-				},
+				ctx.codeFeatures.withoutCompletion,
 				dynamicTagInfo.tag,
 				dynamicTagInfo.offsets[1],
 				dynamicTagInfo.astHolder,
@@ -227,13 +224,13 @@ export function* generateComponent(
 	yield* wrapWith(
 		node.loc.start.offset,
 		node.loc.end.offset,
-		{
+		ctx.resolveCodeFeatures({
 			verification: {
 				shouldReport(_source, code) {
 					return String(code) !== '6133';
 				},
 			}
-		},
+		}),
 		var_componentInstance
 	);
 	yield ` = ${var_functionalComponent}`;
diff --git a/packages/language-core/lib/codegen/template/elementDirectives.ts b/packages/language-core/lib/codegen/template/elementDirectives.ts
@@ -60,11 +60,9 @@ function* generateIdentifier(
 			prop.loc.start.offset,
 			{
 				...ctx.codeFeatures.withoutHighlight,
+				// fix https://github.com/vuejs/language-tools/issues/1905
+				...ctx.codeFeatures.additionalCompletion,
 				verification: false,
-				completion: {
-					// fix https://github.com/vuejs/language-tools/issues/1905
-					isAdditional: true,
-				},
 				navigation: {
 					resolveRenameNewName: camelize,
 					resolveRenameEditText: getPropRenameApply(prop.name),
diff --git a/packages/language-core/lib/codegen/template/elementProps.ts b/packages/language-core/lib/codegen/template/elementProps.ts
