Commit cc9b9d0
perf(tsc): re-introduce global types removal check (#4245)
The issue with the guard clause prior was that the out directory for the .d.ts file
is likely to be a different place from the global types holder file. This meant the
clause was not accurately detecting if it should remove the global types.
The guard clause is needed to some degree as large projects with many emitted files
would run this removal which is fairly slow. vue-tsc is unusable without this guard
clause.
Instead just get the file name from the file being written and the global types holder,
if the dts file starts with the global types holder then perform the global types
removal logic.
This allows for the output and source paths to be different. The removal may run
more than once if similar names are present but it won't run on every file to be emitted.
Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>1 parent 5216e74 commit cc9b9d0
1 file changed
+8
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
27 | 33 | | |
28 | 34 | | |
29 | 35 | | |
| |||
0 commit comments