change basic-encode vocabulary #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following the emerging consensus in #2
Contributor
|
Looks good! I just think the properties ( Also, the file (N.B.: I've done the equivalent changes in w3c/rdf-schema#70.) |
niklasl
reviewed
Dec 9, 2025
Contributor
niklasl
left a comment
niklasl
left a comment
There was a problem hiding this comment.
Changing case of properties to the conventional camelCase for properties (was PascalCase like for classes).
| <li>(<var>b</var>, `rdf:type`, `rdf:PropositionForm`) | ||
| <li>(<var>b</var>, `rdf:PropositionFormSubject`, <var>s</var>) | ||
| <li>(<var>b</var>, `rdf:PropositionFormPredicate`, <var>p</var>) | ||
| <li>(<var>b</var>, `rdf:PropositionFormObject`, <var>o</var>) |
Contributor
There was a problem hiding this comment.
Suggested change
| <li>(<var>b</var>, `rdf:PropositionFormObject`, <var>o</var>) | |
| <li>(<var>b</var>, `rdf:propositionFormSubject`, <var>s</var>) | |
| <li>(<var>b</var>, `rdf:propositionFormPredicate`, <var>p</var>) | |
| <li>(<var>b</var>, `rdf:propositionFormObject`, <var>o</var>) |
| and (<var>b</var>, `rdf:ttObject`, <var>o</var>); | ||
| (<var>b</var>, `rdf:PropositionFormSubject`, <var>s</var>), | ||
| (<var>b</var>, `rdf:PropositionFormPredicate`, <var>p</var>), | ||
| and (<var>b</var>, `rdf:PropositionFormObject`, <var>o</var>); |
Contributor
There was a problem hiding this comment.
Suggested change
| and (<var>b</var>, `rdf:PropositionFormObject`, <var>o</var>); | |
| (<var>b</var>, `rdf:propositionFormSubject`, <var>s</var>), | |
| (<var>b</var>, `rdf:propositionFormPredicate`, <var>p</var>), | |
| and (<var>b</var>, `rdf:propositionFormObject`, <var>o</var>); |
| <p class=note> | ||
| This is one reason why this transformation introduces new vocabulary terms | ||
| (`rdf:TripleTerm`, `rdf:ttSubject`, `rdf:ttPredicate`, `rdf::ttObject`), | ||
| (`rdf:PropositionForm`, `rdf:PropositionFormSubject`, `rdf:PropositionFormPredicate`, `rdf::ttObject`), |
Contributor
There was a problem hiding this comment.
Suggested change
| (`rdf:PropositionForm`, `rdf:PropositionFormSubject`, `rdf:PropositionFormPredicate`, `rdf::ttObject`), | |
| (`rdf:PropositionForm`, `rdf:propositionFormSubject`, `rdf:propositionFormPredicate`, `rdf:propositionFormObject`), |
| <li id="qtt-fresh-bnode">Let <var>b</var> be a fresh blank node.</li> | ||
| <li>Add the association (<var>t</var>, <var>b</var>) to <var>Mₒ</var>.</li> | ||
| <li>Add the triples (<var>b</var>, `rdf:type`, `rdf:TripleTerm`), (<var>b</var>, `rdf:ttSubject`, <var>s</var>), (<var>b</var>, `rdf:ttPredicate`, <var>p</var>), and (<var>b</var>, `rdf:ttObject`, <var>o</var>) in <var>G</var>.</li> | ||
| <li>Add the triples (<var>b</var>, `rdf:type`, `rdf:PropositionForm`), (<var>b</var>, `rdf:PropositionFormSubject`, <var>s</var>), (<var>b</var>, `rdf:PropositionFormPredicate`, <var>p</var>), and (<var>b</var>, `rdf:PropositionFormObject`, <var>o</var>) in <var>G</var>.</li> |
Contributor
There was a problem hiding this comment.
Suggested change
| <li>Add the triples (<var>b</var>, `rdf:type`, `rdf:PropositionForm`), (<var>b</var>, `rdf:PropositionFormSubject`, <var>s</var>), (<var>b</var>, `rdf:PropositionFormPredicate`, <var>p</var>), and (<var>b</var>, `rdf:PropositionFormObject`, <var>o</var>) in <var>G</var>.</li> | |
| <li>Add the triples (<var>b</var>, `rdf:type`, `rdf:PropositionForm`), (<var>b</var>, `rdf:propositionFormSubject`, <var>s</var>), (<var>b</var>, `rdf:propositionFormPredicate`, <var>p</var>), and (<var>b</var>, `rdf:propositionFormObject`, <var>o</var>) in <var>G</var>.</li> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the emerging consensus in #2