Commit 4e7480c
committed
Refactor fullscreen rejection handling to use WebIDL react pattern
This commit modernizes how the Screen Orientation specification responds to
fullscreen request rejections by using the WebIDL 'react' concept instead
of the previous flag-based approach.
Changes:
- Replace flag-based 'pending fullscreen request flag unset due to rejection' pattern
- Use WebIDL 'react' pattern with 'pending fullscreen request promise'
- Update reference to use proper 'pending fullscreen request flag' terminology
- Extract duplicated descendant document logic into helper algorithm 'reject descendant document orientation promises'
- Add clarifying notes for algorithm logic and same-origin security restrictions
- Maintain all existing algorithm behavior while modernizing the specification architecture
This enables cleaner, more maintainable specification text that follows modern
WebIDL patterns for promise-based APIs and eliminates code duplication. The change
complements the fullscreen spec changes in whatwg/fullscreen that add both the
exported flag and promise definitions needed for this integration.
Fixes #254
Fixes #2551 parent 245ed44 commit 4e7480c
1 file changed
+60
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
859 | 859 | | |
860 | 860 | | |
861 | 861 | | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
862 | 884 | | |
863 | 885 | | |
864 | 886 | | |
865 | 887 | | |
866 | 888 | | |
867 | 889 | | |
868 | 890 | | |
869 | | - | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
870 | 917 | | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
871 | 922 | | |
872 | | - | |
873 | | - | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
874 | 926 | | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
875 | 932 | | |
876 | 933 | | |
877 | 934 | | |
| |||
0 commit comments