House cleaning

Author: hirsch88

README.md

@@ -73,5 +73,11 @@ The port will be displayed to you as `http://0.0.0.0:3000` (or if you prefer IPv
 ## License
  [MIT](/LICENSE)
 
+## ToDo's
+https://blog.risingstack.com/10-best-practices-for-writing-node-js-rest-apis/
+[ ] Add api doc - http://apidocjs.com
+[ ] Add black box testing https://www.npmjs.com/package/supertest
+
+
 ---
 Made with ♥ by Gery Hirschfeld ([@GeryHirschfeld1](https://twitter.com/GeryHirschfeld1)) and [contributors](https://github.com/w3tecch/express-typescript-boilerplate/graphs/contributors)

build/tasks/docs.js

@@ -8,7 +8,7 @@
     "install:dev": "yarn install && npm run install:typings",
     "install:clean": "npm prune && ./node_modules/.bin/typings prune",
     "serve": "./node_modules/.bin/nodemon --watch 'src/**/*.ts'",
-    "serve:debug": "./node_modules/.bin/nodemon --watch 'src/**/*.ts' --debug=6666",
+    "serve:debug": "npm run serve -- --debug=6666",
     "lint": "./node_modules/.bin/gulp lint",
     "test": "NODE_ENV=test ./node_modules/.bin/jest --coverage",
     "build": "./node_modules/.bin/gulp build",
@@ -17,7 +17,6 @@
     "db:migrate": "./node_modules/.bin/knex migrate:latest",
     "db:migrate:rollback": "./node_modules/.bin/knex migrate:rollback",
     "db:seed": "./node_modules/.bin/knex seed:run",
-    "db:refresh": "npm run db:drop && npm run db:migrate",
     "start": "node src/index.js"
   },
   "repository": "git+ssh://git@github.com/w3tec/express-typescript-boilerplate.git",
@@ -57,8 +56,6 @@
     "@types/express": "^4.0.35",
     "@types/faker": "^4.1.0",
     "@types/helmet": "0.0.34",
-    "@types/inversify": "^2.0.33",
-    "@types/inversify-express-utils": "^2.0.0",
     "@types/jest": "^19.2.2",
     "@types/knex": "0.0.47",
     "@types/lodash": "^4.14.63",
@@ -89,7 +86,6 @@
     "gulp-rename": "^1.2.2",
     "gulp-sourcemaps": "^1.9.1",
     "gulp-tslint": "^7.0.1",
-    "gulp-typedoc": "^2.0.2",
     "gulp-typescript": "^3.1.4",
     "gulp-zip": "^3.2.0",
     "helmet": "^3.4.0",
@@ -101,6 +97,7 @@
     "knex": "^0.12.7",
     "lodash": "^4.17.4",
     "morgan": "^1.7.0",
+    "mysql": "^2.13.0",
     "nodemon": "^1.11.0",
     "path": "^0.12.7",
     "pg": "^6.1.5",
@@ -113,7 +110,7 @@
     "ts-jest": "^19.0.11",
     "ts-node": "^2.0.0",
     "tslint": "^4.3.1",
-    "typescript": "^2.2.1",
+    "typescript": "^2.3.0",
     "typings": "^2.1.0",
     "winston": "^2.3.1"
   },

package.json

@@ -2,7 +2,7 @@ import { IsEmail, IsNotEmpty } from 'class-validator';
 import { RequestBody } from '../../core/api/RequestBody';
 
 /**
-* This class is used for create request. Create a new instance
+ * This class is used for create request. Create a new instance
  * with the json body and than call .validate() to check if
  * all criteria are given
  *

src/api/requests/UserCreateRequest.ts

@@ -17,7 +17,6 @@ import container from './container';
  * all your custom middlewares and routes
  */
 const app = Bootstrap.getApp()
-
     // Enabling the cors headers
     .options('*', cors())
     .use(cors())

src/app.ts

@@ -1,19 +1,23 @@
 {
     "compilerOptions": {
+        "target": "es6",
         "module": "commonjs",
-        "target": "es5",
         "moduleResolution": "node",
+        "sourceRoot": "src",
+        "typeRoots": [
+            "node_modules/@types"
+        ],
         "sourceMap": true,
-        "noUnusedLocals": true,
+        "alwaysStrict": true,
+        "strict": true,
         "noUnusedParameters": false,
+        "noImplicitAny": false,
         "experimentalDecorators": true,
         "emitDecoratorMetadata": true,
-        "strictNullChecks": true,
         "lib": [
-            "es6",
+            "es2017",
             "dom"
-        ],
-        "noImplicitAny": false
+        ]
     },
     "filesGlob": [
         "typings/**/*.d.ts",

tsconfig.json

@@ -1,9 +1,14 @@
 {
     "rules": {
+        "align": [
+            true,
+            "parameters"
+        ],
         "class-name": true,
         "comment-format": [
             true
         ],
+        "jsdoc-format": true,
         "curly": true,
         "eofline": true,
         "forin": true,