Improve auth faker

Author: hirsch88

test/e2e/api/users.test.ts

@@ -24,7 +24,7 @@ describe('/api/users', () => {
     beforeAll(async () => synchronizeDatabase(settings.connection));
     beforeAll(async () => factory = getFactory(settings.connection));
     beforeAll(async () => bruce = await factory.runSeed<User>(CreateBruce));
-    beforeAll(async () => authServer = fakeAuthenticationForUser(bruce));
+    beforeAll(async () => authServer = fakeAuthenticationForUser(bruce, true));
 
     // -------------------------------------------------------------------------
     // Tear down

test/e2e/utils/auth.ts

@@ -3,11 +3,15 @@ import { User } from '../../../src/api/models/User';
 import { env } from '../../../src/core/env';
 
 
-export const fakeAuthenticationForUser = (user: User): nock.Scope => {
-    return nock(env.auth.route)
-        .persist()
+export const fakeAuthenticationForUser = (user: User, persist = false): nock.Scope => {
+    const scope = nock(env.auth.route)
+        // .persist()
         .post('')
         .reply(200, {
             user_id: `auth0|${user.email}`,
         });
+    if (persist) {
+        scope.persist();
+    }
+    return scope;
 };