Autocomplete for `make` doesn't work when Makefile uses `include` directive

[lucieleblanc]

Link to @sarvesh4396's main issue: warpdotdev/warp#11705

[oz-for-oss]

This issue has been labeled ready-to-implement and is open for contributions involving code changes. If you'd like to tackle it, feel free to open a pull request against this issue. You can also comment @oz-agent on this issue to have the bot draft an implementation PR automatically.

[oz-for-oss]

@lucieleblanc

Here's what I found while triaging this issue:

The linked Warp report includes a clear reproduction, and this looks actionable without more information from the reporter. An open fix PR already exists in this repository: #275.

Maintainer details

I concluded that make target completion misses targets defined in included Makefiles because the current generator reads only the top-level Makefile instead of following include directives..

Triage summary

This is a reproducible make completion bug in the command-signatures generator. The linked Warp issue includes a minimal project where the root Makefile includes makefiles/main.mk and makefiles/experiment.mk; Warp only suggests the root help target and misses targets such as up-main and down-main from included files.

Reproducibility

High. The linked report includes concrete Makefile contents, the exact completion action (make + Tab), environment details, and confirmation that another terminal shows the included targets. No reporter follow-up is needed to make this actionable.

Likely root cause

command-signatures/src/generators/make.rs wires the make list_targets generator to cat [Mm]akefile, then parses only that command output for targets. Because this command reads only the top-level Makefile, it does not follow include, -include, or sinclude directives, so targets declared solely in included files never reach list_targets_post_process. command-signatures/json/make.json maps make target arguments to that generator.

There is already an open implementation PR, #275, that appears to address this by following include directives recursively.

Duplicate check

I enumerated all open issues in warpdotdev/command-signatures, excluding PRs and this issue, and checked recently closed issues from the last 7 days. I did not find two or more likely duplicate issues, so duplicate_of is empty.

This is my automated analysis and may be incorrect. A maintainer will verify the details.

Powered by Oz