Zsh suggestions/completions don't work for Justfiles (possibly other files too)

[r614]

Discord username (optional)

No response

Describe the bug

Open a shell in Warp, type just <tab> - will show file suggestions instead of just commands in the current directory's Justfile.

May extend to all Zsh autocompletions, I haven't tested it throughly.

To Reproduce

Use a Zsh terminal and install Just, Autocompletions

Create a Justfile:

set shell := ["bash", "-c"]

@default:
  just --list --unsorted

@test:
  echo 'test'

Try typing just and press Tab

Expected behaviour

Shows the zsh suggestions instead of files in the current dir - in this case, the Just commands

Screenshots

Operating System

MacOS

OS Version

12.2

Shell Version

zsh 5.8

Warp Version

v0.2022.09.20.08.08.stable_01

Additional context

No response

Does this block you from using Warp daily?

Yes

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

[ericsampson]

that would be awesome.

[dannyneira]

Thanks for this, marking this as a feature request for just completion support! Please +1 this request as it helps us gauge interest. We will post any updates here.

[oz-for-oss]

This issue has been labeled ready-to-implement and is open for contributions involving code changes. If you'd like to tackle it, feel free to open a pull request against this issue. You can also comment @oz-agent on this issue to have the bot draft an implementation PR automatically.

[warp-agent-staging]

just completions are now implemented.

Warp's just signature previously carried only Fig-style JS generators for the recipe argument, which Warp doesn't execute — so the completer fell back to filesystem path suggestions, which is the behavior reported here.

• Complete just completions: Justfile recipe generator command-signatures#307 (merged) adds a native recipe generator that reads recipes from the current Justfile via just --dump --dump-format json, falling back to just --list / just --summary. Recipe suggestions are prioritized above path suggestions, private recipes follow just's own listing behavior, doc comments become descriptions, and just --set completes variables. A missing Justfile or a just failure yields an empty list rather than an error.
• [Completions] Bump command-signatures to 50fe37c1 #14772 bumps the client's warp-command-signatures pin to that commit, which is what ships it to Warp. It will land in a subsequent release.

A follow-up is already open to make the generator arity-aware, so parameter positions on a parameterized recipe (just deploy <TAB>) stop offering further recipe names.

Closing as implemented. Thanks for the clear report and the repro Justfile.