Skip to content

Commit ab0c6ab

Browse files
authored
fix(accessibility): use expand function in toggleExpanded and remove misleading hint function (#852)
Co-authored-by: panku51 <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>
1 parent 86573e0 commit ab0c6ab

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/adapters/MeetingsJSONAdapter/controls/SwitchMicrophoneControl.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export default class SwitchMicrophoneControl extends MeetingControl {
4949
noOptionsMessage: 'No available microphones',
5050
options: null,
5151
selected: null,
52-
hint: 'Use arrow keys to navigate between microphone options and hit "Enter" to select.',
5352
});
5453
observer.complete();
5554
} else {

src/adapters/MeetingsJSONAdapter/controls/SwitchSpeakerControl.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export default class SwitchSpeakerControl extends MeetingControl {
5555
noOptionsMessage: 'No available speakers',
5656
options: null,
5757
selected: null,
58-
hint: 'Use arrow keys to navigate between speaker options and hit "Enter" to select.',
5958
});
6059
observer.complete();
6160
} else {

src/components/inputs/Dropdown/Dropdown.jsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@ export default function Dropdown({
5656
const expand = (withKey) => setExpanded({withKey});
5757
const toggleExpanded = (withKey) => {
5858
if (!disabled) {
59-
setExpanded(expanded ? undefined : {withKey});
59+
if (expanded) {
60+
collapse();
61+
} else {
62+
expand(withKey);
63+
}
6064
}
6165
};
6266

0 commit comments

Comments
 (0)